(Unintentional) dependency in C++ static constructor order; causes SIGFPE when source files are reordered about dyninst HOT 1 CLOSED

ran across a case in common/CMakeLists.txt where a source file is listed in the _private_headers array

I sometimes impress myself with the stupid mistakes I make.

After applying the above patch, build Dyninst and attempt to load libcommon.so. The result is an FPE (divide by zero):

Oh, SIOF, you haunt my dreams.

For additional fun, there is an extra copy of MachRegister.h in the _public_headers list. I really made a mess here.

@kupsch I fixed this by moving the definitions of names and all_regs into dyn_regs.C so that they are in the same TU as the definitions of the registers and guaranteed to be initialized in order. It's a little ugly because it would make them global symbols in libcommon, but we can leave them unexported to keep them from escaping further. Thoughts?

from dyninst.