Issues with Static Instruction Insertion using Dyninst about dyninst HOT 4 CLOSED

Can you elaborate on what you mean by "not correctly insert the instructions" and "for what files", maybe provide the files you want to instrument if possible?

from dyninst.

Thank you for your response. I've uploaded an example that illustrates the issues I'm encountering to Archive.zip. The archive contains three files: rewrite.log, rewrite_error.log and pbzip2-0.9.4_gcc-m32.bin.

• rewrite.log lists the instructions I aim to instrument into the binary.
• rewrite_error.log provides the debug messages generated during the process.
• pbzip2-0.9.4_gcc-m32.bin is the file to be instrumented.

One specific issue I observed is with the instructions at some address like 0x4014f4, which were not instrumented correctly. Additionally, there is a warning in the logs, but I'm unsure of its implications or how it might be affecting the instrumentation process.

Could you help me understand the warning's significance and suggest any steps to resolve the incorrect instrumentation issue?

from dyninst.

@Ouhznehc

So the problem here is Dynisnt concluded that the function main has unresolvable control flow and marked the function as non-instrumentable. (ie. jmp eax at 0x4015f4)

As a result, none of the addresses that you have provided that sits in main got instrumented.
I'll discuss with other maintainers to see if we can add some warning/error to make this easier to spot. (It is pretty hard to spot even for someone who is familiar with the code base).

from dyninst.

@bbiiggppiigg

Thanks!
I have already found this problem by running my program with DYNINST_DEBUG_RELOC=1, and got the following output:

ADDRSPACE::Relocate called; modified functions reports 1 objects to relocate.
Function main is non-instrumentable, skipping

I'll close this issue, thank you for your help!

from dyninst.