durasj / webamp-desktop Goto Github PK

Transparency on Windows has a problem of not receiving the events if it's blurred in the foreground. On Linux we have to do polling. Both could be theoretically better if they would use setShape. We already store rectangles for both since we are tracking the webamp windows. Left clicky could then be applied on both Linux and Windows.

Unfortunately, setShape is currently experimental and doesn't work on the mac.

Tauri is a small Rust wrapper around web views native to that platform. The resulting bundle would be a couple of MB.

I've spent an hour or two playing around with it.

Blockers:

• Ignoring mouse events doesn't work. At least on Fedora. There is also no mouse event forwarding.
• Music playback is broken
• Window title is there even with hiddenTitle: true.
• There are some weird artefacts when launching.

It would be still possible to make it work, but:

• The window would have to be a minimum bounding rectangle so the transparency problems would be minimized. Maybe by adding some "on hover" event handler that would maximize the window when the user is likely to change the window composition?
• Context menus would have to be native.
• Playback would have to be native.

It would be great to support native APIs of the operating systems. For Mac, there was good work done by the @captbaritone in the #10. Later, we can look at https://www.npmjs.com/package/electron-media-service and try to port it to N-API.

For Linux, we can use https://www.npmjs.com/package/mpris-service.

For Windows, https://docs.microsoft.com/en-us/windows/uwp/audio-video-camera/system-media-transport-controls is the way to go. We can hopefully use automatically generated NodeRT module.

First of all thank you for bringing back some really cool old memories :)
Now, usually with AppImageLauncher you can integrate an appimage simply into the system. But for this appimage it simply does not work. It only works to launch the app itself and that's pretty much it. Is this something to do with webamp itself?
Cheers!

@captbaritone mentioned this solution in #494:

[...]the window stick to the edge of the first screen, and has to be pushed a bit farther into the next screen before the change actually happens. When it does cross the threshold, it takes the other windows with it? Basically there's some implied friction/resistance at the boundary.

Just an idea. I'd love to hear others if people have them. One question is: what formation should the non-moving windows have when they move to the new screen? I think ideally they would have the same (or similar) positions to those that they had on the old screen. Obviously we would need to make adjustments if the screen size of the new screen is smaller, but perhaps we could keep it proportional.

Is your feature request related to a problem? Please describe.
Llama Whippin' Intro is the famous default track in the Winamp.

Describe the solution you'd like
Llama Whippin' Intro should be bundled as an initial track.

Additional context
Unfortunately, it seems the building won't include the .mp3 file in the package.

C:\LavanyaDeepak\Personal\webamp-desktop>yarn start
yarn run v1.22.10
$ yarn run build && electron .
$ yarn run copy && yarn build:src
$ cp -r ./bundled/* ./dist
'cp' is not recognized as an internal or external command,
operable program or batch file.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

The default position on webamp is center and I guess uses absolute positioning on the screen. Is there a way to override this and control where it should be rendered.

could someone possibly develop antivirus protection

I've tried an m3u and xspf files, but it doesn't seem to like playing internet radio

eg:

#EXTM3U
#PLAYLIST:Online radio: TOP Music (www.radio.pervii.com)
#EXTINF:-1 tvg-logo="" group-title="TOP Radio - radio.pervii.com", Radio Pro Manele Romania WwW.RadioProManele.Com - 128 kbit/s
http://radiopromanele.zapto.org:8000/stream/1/
#EXTINF:-1 tvg-logo="https://www.radio.pervii.com/logo/30255.jpg" group-title="TOP Radio - radio.pervii.com", Apintie Suriname - 128 kbit/s
http://31.186.172.137:7000/stream/1/
#EXTINF:-1 tvg-logo="https://www.radio.pervii.com/im/7/1549630997.jpg" group-title="TOP Radio - radio.pervii.com", ORF Radio Oberösterreich - 128 kbit/s
http://185.85.28.151:80/stream/1/
#EXTINF:-1 tvg-logo="https://www.radio.pervii.com/im/2/1555241792.jpg" group-title="TOP Radio - radio.pervii.com", Eldoradio - 256 kbit/s
http://81.92.238.33:80/stream/1/

Or... is this already enabled, but I'm missing how to do it?

Is your feature request related to a problem? Please describe.
@captbaritone proposed:

I wonder if we should expose some way for Webamp Desktop to use Electrons context menus instead of the fake ones that I made.

Describe the solution you'd like
We'll use Menu API from Electron to add the context menu via some new API. Idea for implementation from @captbaritone is

Probably the best thing to do would be for me to transition to using an internal API that matched the Electron API. Then I could just expect you to pass me a function that accepts a menu template and renders it.

Describe alternatives you've considered
I could receive an array of options and attach some callbacks for open/close but that seems a bit more complicated.

We are currently overriding thumbnail on the Windows by calling setThumbnailClip with just the main window.

Something similar can be done on the Mac by setting miniwindowimage before the window is minimized. Electron currently doesn't seem to support it.

This would mean we could hide that weird miniature that is there because we are using a large transparent window for webamp.

Hi there. I'm using Manjaro Linux. Would very much like to install this app.
I know there's an AppImage. But I want the app to be installed instead so that I can use different winamp skins and such.
And besides. Flatpaks are available in the distro's app store.

There is currently WIP branch https://github.com/durasj/webamp-desktop/tree/webamp-real-dep using the webamp as a dependency instead of the custom bundle we currently have.

It would be nice to finalize it, bump other packages as well and release that as a new version together with media keys and other stuff added in the meantime.

Hi,
On Ubuntu 18.10 I ran the app image, it just quit immediately with seemingly nothing happening.

Cheers
S

This project could be switched to Bun - just for fun, no practical reason - but it's currently blocked by oven-sh/bun#4959.

Please, consider supporting Flatpak and publishing Webamp desktop on Flathub.

Describe the bug
On Windows I am not able to track the webamp window on another monitor (Dual screen setup)(

To Reproduce
Steps to reproduce the behavior:

1. Open Webamp
2. Have at least 2 screens
3. Try to drag and drop webamp on another screen
4. It just stops on the edge of the screen

Expected behavior
Dragging on another screen should be possible

Desktop (please complete the following information):

• Windows 10

I see this error:

I am using the latest appimage