Git Product home page Git Product logo

Comments (5)

weshaggard avatar weshaggard commented on July 18, 2024

@steveharter while I can understand that we might not want these concrete types is there actually any bad things that come from keeping them? I don't think just the fact that someone might case to them is a good enough reason to exclude them.

from standard.

steveharter avatar steveharter commented on July 18, 2024

The types will not be usable (PNSE on every member) and not created by corefx nor by anyone else since the ctor is internal. The class should not have been public to begin with. So if we keep them it would be "just for contract reasons" meaning compile works but nothing at run-time. Isn't it better to change any consuming code at compile-time vs later at run-time when the usage is destined to fail (at least on corefx)?

from standard.

KevinRansom avatar KevinRansom commented on July 18, 2024

@weshaggard I'm not sure that shipping useless types is an easily defensible position. That the types can only be successfully used on Windows may be an argument to include them ... but it is not a strong one. Although perhaps including them and marking them deprecated them might be an interesting choice.

from standard.

weshaggard avatar weshaggard commented on July 18, 2024

@weshaggard I'm not sure that shipping useless types is an easily defensible position.

The principals for .NET Standard is to include everything in the interesction unless we have a reason not to (see https://github.com/dotnet/standard/tree/master/docs/netstandard-20). There are lots of things in netstandard that might be considered useless but it really depends on your prospective.

For these particular types given they are leaf node types which don't have any real usage in our data and are windows specific I'm OK excluding them. I will exclude them.

@terrajobst any thoughts?

from standard.

terrajobst avatar terrajobst commented on July 18, 2024

Both types have extremely low usage. I'd be fine with removing them.

from standard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.