Git Product home page Git Product logo

bubblefactory's People

Contributors

donaldhays avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

bubblefactory's Issues

Switch to MBC5

Currently setting cartridge type to 0x09: ROM+RAM+Battery, which was unused by licensed cartridges. Weird save behavior on SameBoy may be attributable to this. Cartridge type 0x1B will set to MBC5+RAM+Battery.

Don't get the node scripts working

$node ../img2gb -n logo data/gfx/logo.png src/data_gfx_logo.c
node[248790]: ../src/node_zlib.cc:324:static void node::{anonymous}::CompressionStream<CompressionContext>::Write(const v8::FunctionCallbackInfo<v8::Value>&) [with bool async = false; CompressionContext = node::{anonymous}::ZlibContext]: Assertion `Buffer::HasInstance(args[4])' failed.
 1: 0x5597088d0fd1 node::Abort() [node]
 2: 0x5597088d1067  [node]
 3: 0x5597089ae8dd  [node]
 4: 0x559708b1a257 v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) [node]
 5: 0x559708b1b03e  [node]
 6: 0x559708b1b532  [node]
 7: 0x559708b1b7e6 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [node]
 8: 0x5597092e8859  [node]
[1]    248790 abort (core dumped)  node ../img2gb -n logo data/gfx/logo.png src/data_gfx_logo.c

memoryCopy()

What’s the reasoning behind memoryCopy()?
It looks pretty much like memcpy
Is it to avoid 16bit n and to avoid putting the arguments on the stack?

Edit:
I think it was mostly for reusing n and to avoid the stack.
I kept n in a variable with the new calling convention, that generates smaller code than memcpy, but I didn’t look at speed.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.