Git Product home page Git Product logo

ios-ftp-server's Issues

Patch for /trunk/Classes/FtpConnection.m

-(void)doRetr:(id)sender arguments:(NSArray*)arguments:
Here a small modification on the method called. Data is loaded in memory on 
demand, so only a small
amount of memory is required even for huge files:[ NSMutableData 
dataWithContentsOfMappedFile:filePath ]


-(NSString*)fileNameFromArgs:(NSArray*)arguments : 
I made changes to get the filename correctly from the arguments following the 
command string
Generally all the arguments following the command (according to the FTP rfc are 
not modifiers, but
the filenames.

Original issue reported on code.google.com by [email protected] on 13 Jul 2011 at 10:23

Attachments:

fix crash from ^D

around line 396 of FtpConnection.m there is the following code:

NSData *strData = [data subdataWithRange:NSMakeRange(0, [data length] - 2)];    
                        // remove last 2 chars

The problem is that if there is a ^D (EOF) then there won't be two characters 
and the server will crash.
here's my fix
  NSData *strData = [data subdataWithRange:NSMakeRange(0, [data length]>2?[data length] - 2:[data length])];                              // remove last 2 chars [JMZ-make sure we have at least 2 chars, e.g. a ^D will give us just 1 and this crashes]


Original issue reported on code.google.com by [email protected] on 12 Feb 2011 at 8:19

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.