djh365 / ios-ftp-server Goto Github PK

around line 396 of FtpConnection.m there is the following code:

NSData *strData = [data subdataWithRange:NSMakeRange(0, [data length] - 2)];    
                        // remove last 2 chars

The problem is that if there is a ^D (EOF) then there won't be two characters 
and the server will crash.
here's my fix
  NSData *strData = [data subdataWithRange:NSMakeRange(0, [data length]>2?[data length] - 2:[data length])];                              // remove last 2 chars [JMZ-make sure we have at least 2 chars, e.g. a ^D will give us just 1 and this crashes]

to be coherent with the change to MyNetworkController

to be coherent with the change to MyNetworkController

-(void)doRetr:(id)sender arguments:(NSArray*)arguments:
Here a small modification on the method called. Data is loaded in memory on 
demand, so only a small
amount of memory is required even for huge files:[ NSMutableData 
dataWithContentsOfMappedFile:filePath ]


-(NSString*)fileNameFromArgs:(NSArray*)arguments : 
I made changes to get the filename correctly from the arguments following the 
command string
Generally all the arguments following the command (according to the FTP rfc are 
not modifiers, but
the filenames.

I had to change the name of this class name to MyNetworkController so that it 
doesn't mess with the MessageUI.framework one

to be coherent to the renaming to MyNetworkController of the class

I had to change the name of this file to MyNetworkController.h so that it 
doesn't mess with the MessageUI.framework one