[Issue Report]: Overflow with Acolyte Amulet? about devilutionx HOT 4 OPEN

This is one of the reasons why I'd actually advocate for the menu and the game being 2 separate processes.

That wouldn't help here. Stash saves item data in SP save format so it remembers the HP/mana values assigned to the item when it was picked up. Before 1.5.1, we used the heroitems file in the character saves to do the same for items in the player's inventory. But recently with the introduction of the item validation logic, we switched back to the vanilla way of regenerating the item on new game. So now there's a bit of a difference between leaving an item in your stash and holding it in your inventory when you create a new game.

from devilutionx.

I don't know if this is some sort of overflow or if the amulet decided to remember my Sorcerer's massive mana pool for some reason and apply that on my Warrior.

Loading the game up again, there he is, but this time the health and HP values are normal, so it seems self-correcting, in a way.

You are probably onto something there... if this goes away when reloading, it is most likely state that wasn't correctly cleared between one game and the other (which is what happens with the vanilla game in several scenarios, such as "refreshing wirt items", or "difficulty levels in normal" etc).

This is one of the reasons why I'd actually advocate for the menu and the game being 2 separate processes.

from devilutionx.

Stash saves item data in SP save format so it remembers the HP/mana values assigned to the item when it was picked up.

Had no idea about that. Thanks for pointing it out!

from devilutionx.

#5771

from devilutionx.