devotedmc / bastion Goto Github PK

Same as /janame, just something that will show up in /bsl and /bsi. Would be very useful.

Hi
I want to make a crafting recipe for the bastions but I don't know what the item ids are
Help is appreciated :)
Edit: just had to use the correct lore/name of block

same as Failed migration: You have an error in your SQL syntax

https://www.toptal.com/developers/hastebin/wugavomute.sql

It pretends in cache but any inspection method still returns false apparently.

Clicking blocks that are definitely only in the radius of a single bastion (while in /bsi) will say "A bastion block prevents other from building" twice in chat every time.

So, it would be best to add /ctr prevention to per-bastion-type config, so that it can be enabled or disabled as appropriate. For instance, Claims bastions in Devoted's setup require direct destruction (they don't block placement of blocks) so it wouldn't make sense for them to block /ctr use, when they don't block /ctf use. Since at present it's a global setting, this makes it hard for me to turn it on at all.

Thoughts? Have I misunderstood?

The current behaviour when Bastion A & Bastion B is that in the overlapping area, a player who is not on group A&B cannot place or pearl within that field. My proposed change would be to alter this behaviour in order to bring a balance element to Bastion.

New behaviour:
When two bastions are placed on different groups and have an overlap, We take the most recently placed bastion and define that as the 'Anti-bastion', the reason for this is that the new bastion will begin to assault the original bastion or in this case, the oldest bastion. The 'Anti-bastion' would break at a rate that is defined by the attackers that stand within the area of both bastions overlap.

Now that the original bastion is being attacked, this overlap zone becomes a zone that both parties have access to. The idea now however is to multiply the break effect of the anti-bastion by however many people are on the group of the anti-bastion. So 1 person stand in the area is equal to 1 person placing blocks, where as 5 = 5 etc.

Where as for the defence, their objective is to simply push out the attackers from that area so that their bastions are not being attacked.

The dynamic this brings is that vaults become more PvP focused which is the fun part of vault battles and gets away from the meta of attacking a vault being a 12hr block placing simulator.

Looking for comments and thoughts on these changes.

If the elytra explosion feature is enabled for bastions and a player flies and explodes close enough to the bastion to destroy it the bastion block is destroyed but the bastion remains.

Title.

Water that generated in will flow into bastion field.

Has always been this way.

Hi again!

I got the plugins to load correctly despite the error I get on startup from NameLayer. My problem tho is that placing my bastion block(Diamond Block) and reinforcing it does nothing, Bastions don't activate! Do I need FactoryMod to use Bastion? Because I just hoping players could use diamond blocks on their own to protect their claims.

I have no errors on startup with Bastion now that I switched to MariaDB.

I also had a small error with JukeAlert that players aren't notified when a player destroys another persons Jukebox.

I was hoping to get my server up soon. I'm sorry to keep bothering you!

Presumably the intended behavior is not being able to push ANY blocks into a bastion field, but currently, if one is placed 2 blocks outside, then a cobble or whatever placed 1 block outside (i.e. the closest you can place it without being blocked), and then you activate the piston, it will push the block successfully into the field. If cycling with a second block, it won't.

https://github.com/DevotedMC/Bastion/blob/master/src/main/java/isaac/bastion/listeners/BastionInteractListener.java#L122

See source issue: Civcraft#49

Steps to repro:

1. /bsi
2. Right click ground or bastion block

Modify the following code segments:

https://github.com/DevotedMC/Bastion/blob/master/src/main/java/isaac/bastion/listeners/BastionInteractListener.java#L124

https://github.com/DevotedMC/Bastion/blob/master/src/main/java/isaac/bastion/listeners/BastionInteractListener.java#L163

and anywhere else storage.createBastion is called.

Modify where if false is returned, properly return the bastion to the Pending list, as here:

https://github.com/DevotedMC/Bastion/blob/master/src/main/java/isaac/bastion/listeners/BastionInteractListener.java#L143

so that player can then retrieve placed bastion or have someone else reinforce it, etc.

I'm getting a MySQL syntax error when trying to use the plugin. "[Bastion] Migration 1 ] Failed migration: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IF NOT EXISTS bastion_type VARCHAR(40) DEFAULT 'citybastion'' at line 1".

My Minecraft version is the latest one, Spigot 1.13.2, but this doesn't seem to be an issue with my Minecraft version. The syntax is wrong in the MySQL.

[21:49:30] [Server thread/INFO]: [Bastion] Enabling Bastion v2.2.3
[21:49:30] [Server thread/INFO]: [Bastion] Loading Bastion type citybastion
[21:49:30] [Server thread/INFO]: [Bastion] Bastion type citybastion loaded: citybastion: LEGACY_NETHER_WART_BLOCK(0) name:City Bastion lore[1]: [This bastion will protect your plot] scale[100->0.2 50cb wm86400000 cd2000 ed0 rd0 iYtrue bte1 doRtrue oDDfalse pearls[false] elytra[true: rMtrue sc1 dobtrue Dobfalse eobtrue eos0.0]
[21:49:30] [Server thread/INFO]: [Bastion] Loading Bastion type claimbastion
[21:49:30] [Server thread/INFO]: [Bastion] Bastion type claimbastion loaded: claimbastion: LEGACY_BONE_BLOCK(0) name:Claim Bastion lore[1]: [This bastion will protect your claims] scale[100->0.2 300r wm86400000 cd2000 ed0 rd0 iYtrue bte1 doRfalse oDDtrue pearls[false] elytra[false]
[21:49:30] [Server thread/INFO]: [Bastion] Loading Bastion type bastion
[21:49:30] [Server thread/INFO]: [Bastion] Bastion type bastion loaded: bastion: LEGACY_SPONGE(0) name:Bastion lore[1]: [this one is hellaz] scale[100->0.2 10r wm86400000 cd2000 ed0 rd0 iYtrue bte1 doRtrue oDDfalse pearls[true: midtrue rMtrue sc2 cobtrue dfBtrue apofalse] elytra[true: rMtrue sc1 dobfalse Dobtrue eobtrue eos0.0]
[21:49:30] [Server thread/INFO]: [Bastion] Preparing to generate ConnectionPool for Bastion.
[21:49:30] [Server thread/INFO]: [Bastion] Connecting to minecraft@localhost:3,306 using root
[21:49:30] [Server thread/WARN]: Wed Mar 13 21:49:30 EDT 2019 WARN: Establishing SSL connection without server's identity verification is not recommended. According to MySQL 5.5.45+, 5.6.26+ and 5.7.6+ requirements SSL connection must be established by default if explicit option isn't set. For compliance with existing applications not using SSL the verifyServerCertificate property is set to 'false'. You need either to explicitly disable SSL by setting useSSL=false, or set useSSL=true and provide truststore for server certificate verification.
[21:49:30] [Server thread/INFO]: [Bastion] Lock acquired, proceeding.
[21:49:30] [Server thread/INFO]: [Bastion] Bastion database is behind, 3 migrations found
[21:49:30] [Server thread/INFO]: [Bastion] Migration 1 ] Applying
[21:49:30] [Server thread/ERROR]: [Bastion] Migration 1 ] Failed migration: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IF NOT EXISTS bastion_type VARCHAR(40) DEFAULT 'citybastion'' at line 1
[21:49:30] [Server thread/ERROR]: [Bastion] Full Error:
com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IF NOT EXISTS bastion_type VARCHAR(40) DEFAULT 'citybastion'' at line 1
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:1.8.0_201]
at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source) ~[?:1.8.0_201]
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source) ~[?:1.8.0_201]
at java.lang.reflect.Constructor.newInstance(Unknown Source) ~[?:1.8.0_201]
at com.mysql.jdbc.Util.handleNewInstance(Util.java:425) ~[spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at com.mysql.jdbc.Util.getInstance(Util.java:408) ~[spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:944) ~[spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3978) ~[spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3914) ~[spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2530) ~[spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2683) ~[spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2491) ~[spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at com.mysql.jdbc.StatementImpl.executeUpdateInternal(StatementImpl.java:1552) ~[spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at com.mysql.jdbc.StatementImpl.executeLargeUpdate(StatementImpl.java:2607) ~[spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at com.mysql.jdbc.StatementImpl.executeUpdate(StatementImpl.java:1480) ~[spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at com.zaxxer.hikari.pool.ProxyStatement.executeUpdate(ProxyStatement.java:120) ~[CivModCore-1.7.0.jar:?]
at com.zaxxer.hikari.pool.HikariProxyStatement.executeUpdate(HikariProxyStatement.java) ~[CivModCore-1.7.0.jar:?]
at vg.civcraft.mc.civmodcore.dao.ManagedDatasource.doMigration(ManagedDatasource.java:359) [CivModCore-1.7.0.jar:?]
at vg.civcraft.mc.civmodcore.dao.ManagedDatasource.doMigrations(ManagedDatasource.java:323) [CivModCore-1.7.0.jar:?]
at vg.civcraft.mc.civmodcore.dao.ManagedDatasource.updateDatabase(ManagedDatasource.java:295) [CivModCore-1.7.0.jar:?]
at isaac.bastion.Bastion.setupDatabase(Bastion.java:93) [Bastion-2.2.3%20(3).jar:?]
at isaac.bastion.Bastion.onEnable(Bastion.java:40) [Bastion-2.2.3%20(3).jar:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:254) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:340) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:404) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at org.bukkit.craftbukkit.v1_13_R2.CraftServer.enablePlugin(CraftServer.java:436) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at org.bukkit.craftbukkit.v1_13_R2.CraftServer.enablePlugins(CraftServer.java:350) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at net.minecraft.server.v1_13_R2.MinecraftServer.l(MinecraftServer.java:580) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:542) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:420) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at net.minecraft.server.v1_13_R2.DedicatedServer.init(DedicatedServer.java:294) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:698) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_201]
[21:49:30] [Server thread/INFO]: [Bastion] Migration 1 ] Failed.
[21:49:30] [Server thread/WARN]: [Bastion] Bastion failed to apply updates.
[21:49:30] [Server thread/INFO]: [Bastion] Lock released.
[21:49:30] [Server thread/WARN]: [Bastion] Failed to update database, stopping bastion
[21:49:30] [Server thread/INFO]: [Bastion] Disabling Bastion v2.2.3
[21:49:30] [Server thread/ERROR]: Error occurred while disabling Bastion v2.2.3 (Is it up to date?)
java.lang.NullPointerException: null
at isaac.bastion.Bastion.onDisable(Bastion.java:54) ~[?:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:256) ~[spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at org.bukkit.plugin.java.JavaPluginLoader.disablePlugin(JavaPluginLoader.java:364) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at org.bukkit.plugin.SimplePluginManager.disablePlugin(SimplePluginManager.java:423) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at isaac.bastion.Bastion.setupDatabase(Bastion.java:95) [Bastion-2.2.3%20(3).jar:?]
at isaac.bastion.Bastion.onEnable(Bastion.java:40) [Bastion-2.2.3%20(3).jar:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:254) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:340) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:404) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at org.bukkit.craftbukkit.v1_13_R2.CraftServer.enablePlugin(CraftServer.java:436) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at org.bukkit.craftbukkit.v1_13_R2.CraftServer.enablePlugins(CraftServer.java:350) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at net.minecraft.server.v1_13_R2.MinecraftServer.l(MinecraftServer.java:580) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:542) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:420) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at net.minecraft.server.v1_13_R2.DedicatedServer.init(DedicatedServer.java:294) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:698) [spigot.jar:git-Spigot-3cb9dcb-0f708cb]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_201]

Needs a fix. I'd prefer either stopping entity movement or explosions.

Elytra field interaction w/ circle and square field. Intent is to arrest flight outside any field you don't have permission to be in, same as pearls.

Ladders act wonky in bastion fields.

Presumably there's some sort of indexing error, using a 1 instead of a 0 or something. Or perhaps the usage of ++i instead of i++ is to blame? Not sure.

But yeah, for example, if you set blocksToErode to 10, and you put 5 bastions all overlapping each other, then it will take 2x the normal number of block placements to break them all. 1 bastion takes a normal intended amount of time to break, 2 bastions take 2x as long to break, 3 or more also take 2x as long to break.

So it's doing one iteration on the random loop "for free" for some reason.

Might or might not be the same never-actually-fixed-only-avoided issue as issue #16 in the civcraft repository here:
Civcraft#16

Occurs after breaking bastion by block placement

Steps to repro:

1. Break bastion by placing
2. CTI bastion block directly

I made a kit that gives a bastion block, when I place it somewhere the console says:
[Bastion] Pending a bastion at Location{world=CraftWorld{name=world},x=393.0,y=71.0,z=690.0,pitch=0.0,yaw=0.0}
I use /bsi and it says there is "No Bastion Block"
I put the warmup time to 1 and still it says "No Bastion Block"

Having to uncover each bastion to check its health with /cti is rather unreasonable.

Could be added as a hover message.

1. Standing in a bastion field that blocks pearls (blocks: true, midairblock: false), throwing a pearl that hits a PLAYER (specifically, myself) also in the field will still teleport me, while hitting a BLOCK is prevented as intended. (I tried other entities after that, but it did block it correctly when going through items or minecarts)

2. Standing in a field that has "midairblock: false" in the config, I throw a pearl outside the field and it lands far far away from any bastions, and is still blocked at the moment of impact 50 meters away from any bastions? Seems like it should function like vanilla in this case.

3. Standing outside a field that has pearl blocking on but "midairblock: false", and attempting to throw a pearl through it to the other unprotected side, causes the pearl to seemingly get pulled down to the ground as soon as it hits the field, and teleports me just outside of its border at that spot. It seems like it definitely SHOULD just have no effect in this situation (i.e. it should fly through and land on other side and teleport there). That feels like what would be expected with "midairblock: true" instead, at best, although even then shouldn't it just fail, not teleport you to the edge?

Not entirely sure what this means:

[09:12:30 ERROR]: [Bastion] Reinforcement removed without removing bastion, fixed
[09:12:30 WARN]: [Bastion] Failed to set bastion as dead at Location{world=CraftWorld{name=world},x=5995.0,y=74.0,z=4351.0,pitch=0.0,yaw=0.0}
java.sql.SQLException: No value specified for parameter 2
        at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:959) ~[spigot-1.10.2.jar:git-Spigot-72c2605-251a5b6]
        at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:898) ~[spigot-1.10.2.jar:git-Spigot-72c2605-251a5b6]
        at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:887) ~[spigot-1.10.2.jar:git-Spigot-72c2605-251a5b6]
        at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:862) ~[spigot-1.10.2.jar:git-Spigot-72c2605-251a5b6]
        at com.mysql.jdbc.PreparedStatement.checkAllParametersSet(PreparedStatement.java:2205) ~[spigot-1.10.2.jar:git-Spigot-72c2605-251a5b6]
        at com.mysql.jdbc.PreparedStatement.fillSendPacket(PreparedStatement.java:2185) ~[spigot-1.10.2.jar:git-Spigot-72c2605-251a5b6]
        at com.mysql.jdbc.PreparedStatement.executeUpdateInternal(PreparedStatement.java:2052) ~[spigot-1.10.2.jar:git-Spigot-72c2605-251a5b6]
        at com.mysql.jdbc.PreparedStatement.executeUpdateInternal(PreparedStatement.java:2009) ~[spigot-1.10.2.jar:git-Spigot-72c2605-251a5b6]
        at com.mysql.jdbc.PreparedStatement.executeLargeUpdate(PreparedStatement.java:5094) ~[spigot-1.10.2.jar:git-Spigot-72c2605-251a5b6]
        at com.mysql.jdbc.PreparedStatement.executeUpdate(PreparedStatement.java:1994) ~[spigot-1.10.2.jar:git-Spigot-72c2605-251a5b6]
        at com.zaxxer.hikari.pool.ProxyPreparedStatement.executeUpdate(ProxyPreparedStatement.java:61) ~[WordBank-1.0.2.jar:?]
        at com.zaxxer.hikari.pool.HikariProxyPreparedStatement.executeUpdate(HikariProxyPreparedStatement.java) ~[WordBank-1.0.2.jar:?]
        at isaac.bastion.storage.BastionBlockStorage.setBastionAsDead(BastionBlockStorage.java:152) [Bastion-2.0.2.jar:?]
        at isaac.bastion.BastionBlock.destroy(BastionBlock.java:470) [Bastion-2.0.2.jar:?]
        at isaac.bastion.BastionBlock.<init>(BastionBlock.java:50) [Bastion-2.0.2.jar:?]
        at isaac.bastion.storage.BastionBlockStorage.loadBastions(BastionBlockStorage.java:341) [Bastion-2.0.2.jar:?]
        at isaac.bastion.Bastion.setupDatabase(Bastion.java:86) [Bastion-2.0.2.jar:?]
        at isaac.bastion.Bastion.onEnable(Bastion.java:32) [Bastion-2.0.2.jar:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:292) [spigot-1.10.2.jar:git-Spigot-72c2605-251a5b6]
        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:337) [spigot-1.10.2.jar:git-Spigot-72c2605-251a5b6]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:405) [spigot-1.10.2.jar:git-Spigot-72c2605-251a5b6]
        at org.bukkit.craftbukkit.v1_10_R1.CraftServer.enablePlugin(CraftServer.java:373) [spigot-1.10.2.jar:git-Spigot-72c2605-251a5b6]
        at org.bukkit.craftbukkit.v1_10_R1.CraftServer.enablePlugins(CraftServer.java:323) [spigot-1.10.2.jar:git-Spigot-72c2605-251a5b6]
        at net.minecraft.server.v1_10_R1.MinecraftServer.t(MinecraftServer.java:412) [spigot-1.10.2.jar:git-Spigot-72c2605-251a5b6]
        at net.minecraft.server.v1_10_R1.MinecraftServer.l(MinecraftServer.java:377) [spigot-1.10.2.jar:git-Spigot-72c2605-251a5b6]
        at net.minecraft.server.v1_10_R1.MinecraftServer.a(MinecraftServer.java:332) [spigot-1.10.2.jar:git-Spigot-72c2605-251a5b6]
        at net.minecraft.server.v1_10_R1.DedicatedServer.init(DedicatedServer.java:271) [spigot-1.10.2.jar:git-Spigot-72c2605-251a5b6]
        at net.minecraft.server.v1_10_R1.MinecraftServer.run(MinecraftServer.java:535) [spigot-1.10.2.jar:git-Spigot-72c2605-251a5b6]
        at java.lang.Thread.run(Thread.java:745) [?:1.8.0_102]