devmoore94 / textthem Goto Github PK

View Code? Open in Web Editor NEW

5.0 5.0 2.0 759 KB

This is an app to send text messages from the web browser

License: GNU General Public License v2.0

Python 55.48% JavaScript 35.91% CSS 8.61%

textthem's People

Contributors

Stargazers

Watchers

Forkers

mkowoods syntonym ninjadude97

textthem's Issues

Path to static

At the moment the path to static/nouns.txt is given given relative: path_to_nouns = "static/nouns.txt". This is a problem if we are executing the module somewhere else then in . e.g. if your structure is the following way: /home/syntonym/git/textthem/TextThem.py try executing TextThem from the git folder. It will not work (well it will until it hits generateRandom() and then it will crash).

Does any of you know how to fix this? It seems that __file__ can come handy in here, but I'm a bit confused by it. This seems to be read that it can be either relative or absolute. I can't think of a way to solve the problem (utilizing __file__ or not) that would work always. Does anyone of you have a clue?

Login needed?

Since 6ed7e91 login is no longer needed to access the "send text" page. Besides there is now little feedback if you are logged in or not (working on that regarding #6) the login does not seem to provide much functionality. I guess it's good to have some reference if there is abuse (e.g. spam or insults/threats) but without validating there is not much we can do about that. Are there any features planned that need login?

Message not sending. Bad Request.

During one of the pull requests something got changed that is causing a Bad request error when sending a message.

Javascript Indentation

I'm currently working on some javascript and was wondering what to use for indentation. Currently it's 1 tab per indentation level. Random internet sites (like this) suggest 4 spaces. Do you have preferences?

Incorrect html

aboutpage is missing a ">" in line 7.

Also most "orange" sites use the body and head tag in an incorrect way. As far as I know the default structure of a html should be as following:

<!DOCTYPE html>
<html>
  <head>
    <title>sometitle</title>
  </head>
  <body>
    <p>content</p>
  </body>
</html>

i.e. body should enclose all content, especially all div tags. But layout.html looks as following:

<!doctype html>
<title>Text Them</title>
[...]
<div>
[somecontent]
</div>  

<body>
[more content]
</body>  

{% block body %}
{% endblock %}

</div>

This htmlspec says that the html, head and body tags could be ommited.

Add Regex for Phone Numbers

the api call only recognizes phone number of the form1234567890, but users can enter any paasword. Unfortunately the API call is silently failing. should be fixed through simple javascript validation on the client side and regex on the server side. might also want to get response from API Call

Polish?

Even if we don't want to add new features to TextThem (or assure it can send sms) we might want to polish it a bit to add it to our portfolio to showcase it to future employers. By polish I mean:

Add a favicon
Move "Fork me on Github" ribbon to the front but don't let it overlap with the menu on mobile
Polish UI a bit more (e.g. recent messages has disabled scrollbars even when there is no need for scrollbars)
Write unittests for everything
Refactor code to make easier to read/write (if there is a need to)

That are points I have still on mind if thinking of TextThem, but most of these tasks are more or less.. boring and would not realy have an impact.

What do you think?

No license

From the readme, it seems like you're thinking about making this open source (i.e., calling for contributions). If so, you should definitely add a license.

Simple Chat with Attention Notification

I often need a simple way to communicate instant-message like but do not share a communication channel with them e.g: I want to check some details with a friend, but i've got only his email address and we lack common communication programms i.e. she/he only uses whatsapp and I only skype (besides email). While writing emails works, it produces a lot of short emails and sometimes I simply overlook the answer. Optimally I could send an link to my friend and then communicate on that website without any further issues.

There are some tools out there that can be used this way: Etherpad (and lookalikes), but it's more for collaborative writing and is thus a bit "complicated" for simpel chatting. freenode but you need to input a nickname and channel. While this is not really difficult I wouldn't presume my grandmother could to do that.

So a cool thing would be:

Register
Press a "create temporary chat" button that gives you a link like textthem.com/syntonym/a7d39f9123 or maybe anonym
send this link to the person you want to speak with
after your chat the link expires

Additionall features could be:

Customize wether your chat can contain more then 2 people
Configure an endpoint like textthem.com/syntonym/askme. If a person visits this link a chatroom is generated and a notification (via email or sms (or more?), configurable) is send to me, so i can speak asap to this person
permanent chatrooms that save messages
chat between registred users (I guess irc/jabber/whatsapp/skype/whatever is better fitted for this)
person wanting to contact me can additionally input an email address. If he's allready logged out before i can answer he will get a notification when i log in. In this way the app can work be used like email (in fact utilizing email) asynchronously and synchronously (im like)

So, this is a lot. Also it does not really has anything to do with what is TextThem now... But I guess I would use such a service (european here, I guess blower.io is usa only). Technically some kind of AJAX would be needed (does continously polling belong to AJAX?).

What are your thoughts?

What should the Max Text be?

Thought about adding this when I was working on form validation. We should probably have an upper limit maybe 141 characters :)

Login and Register Page

It is possible to override the Stormpath templates with your own. I think we could modify them to fit our theme better.

Add password reset

Simple password reset tab

Phonebook issues.

I added the new changes for the phone book and there a few bugs that I am looking into right now. As well as ensuring proper validation.

Adding New Features Client Side vs Server Side

@syntonym and @DevMoore94

when adding new features do you guys want to primarily implement on the client side(in javascript/jquery) or on the server side(create a python lib).

When I say a feature I mean different things the app might send like locations, data from api calls, etc.

Also, do we want to continue with the current structure of a separarte javascript "library"(.js) for each new feature? If that's the case we should probably assign each implementation to an object so that the variables are restricted in scope.

Let me know what you guys think.

Thanks...

Blower.io Alternative.

We're gonna need to come up with an alternative to blower.io because 50 messages a month is defiantly not enough.

Flag for Production

Everytime I pull the Production value is set back to True. Adding a flag so with python2 TextThem.py --developing would enable Production=False would be a good way to make this configurable.

It's also realy easy to implement:

if "--develooping" in sys.argv:
    Production=False

would be enough. Besides this simple solutions there are command line arguments parser out there:

argparse
optparse (outdated)
click (not builtin)

I could provide an implementation with all of the three, but is it worth the additional package or is the simple solution enough?

Website Design

I really do not care the color scheme and logo of the website. I feel like we could make it look much better. I am not the best at front end design though. I am leaning more towards having the sites main color be green and scrapping the logo or having a new one or something. I know @mkowoods said he was more of a back-end guy and I'm not sure about @syntonym but if anyone knows anyone that could help of we could just all pitch in and work together that would be much appreciated.

New Features

Hey @DevMoore94,

I haven't had a chance to run the Dev Version of the project, but am interested in doing a contribution maybe adding a feature.

before i started is there anything about the API's i should know before adding to the repo?

Clicking the "number" or "text" input fields disables the "Random" button

Seems like the solution to disable the send button also disables the random button. Looking into this.

Merge RandomGenerator with send

Instead of having a seperate page for the random generator a button "Insert random text" could be under the send form that inserts the random words into the form.

Best for this would be probably be a javascript function that calls to an endpoint `textthem.com/random" or something like that and inserts that into the form.

Would that be okay?

Updating the Login interface

@syntonym Stormpath is all based off of templates and can be modified to look however you want. I'm not sure what kind of background you have in HTML and CSS but if you would want to look into that or into changing the layout around. I know that there is a flask-bootstrap library as well. Let me know what you're thinking.

Unittests

Do the unittests work? I'm getting NotImplementedError. Can't copy full traceback right now because.. well I've no idea why it won't copy to clipboard.

Also is the TextThem app somehow imported? All I see is app = Flask(__name__) but __name__ should be __main__ if executed this way if I'm not mistaken. Did I miss something?

Make Updates to Site Responsiveness

I also noticed that the site when formatted on mobile doesn't reformat to fit the screen. Maybe something worth looking into as well.

Homepage design.

Just thought I'd open an issue to start throwing some ideas around about what should be on the homepage?

Grunt

I'm experimenting with Grunt for things like (javscript-) linting. It can handle a lot more, just take a look at the availeble plugins. E.g. minimizing javascript files link. If you also want to give it a try i can upload the required config files. If you don't want to use it I will only use it locally.

Thoughts?