Git Product home page Git Product logo

Comments (9)

endrift avatar endrift commented on July 27, 2024

Gonna be hard to diagnose this without code.

from buildscripts.

PsiLupan avatar PsiLupan commented on July 27, 2024

Gonna be hard to diagnose this without code.

Yeah, unfortunately, it's too large of a project for me to come up with a small test case here. If I can locate my capture card, I'll at least try to get the stack track that I saw and narrow down the difference between Dolphin and console's handling of it that changed with this GCC update.

from buildscripts.

endrift avatar endrift commented on July 27, 2024

https://github.com/PsiLupan/FRAY is this the project in question? You didn't mention what it was that was breaking.

from buildscripts.

PsiLupan avatar PsiLupan commented on July 27, 2024

https://github.com/PsiLupan/FRAY is this the project in question? You didn't mention what it was that was breaking.

It is - Sorry, should've mentioned it.

from buildscripts.

WinterMute avatar WinterMute commented on July 27, 2024

-Wno-implicit-function-declaration is a really terrible idea, you really should give the compiler the function signatures it craves and not just turn that warning off.

from buildscripts.

PsiLupan avatar PsiLupan commented on July 27, 2024

-Wno-implicit-function-declaration is a really terrible idea, you really should give the compiler the function signatures it craves and not just turn that warning off.

It's a hold over from very, very early on where I was mostly writing code for the sake of getting it written, rather than working piece-by-piece. I had forgotten that was still on, but I'll keep that in mind - Thanks

from buildscripts.

WinterMute avatar WinterMute commented on July 27, 2024

Turning that warning back on and adding -Wall I get a lot of warnings that really should be fixed. Implicit function definitions and may be used uninitialized are classic nasal demon triggers.

build.log

I would be massively unsurprised if fixing all those warnings made the issue go away. Can't guarantee it will but I've seen far too many problems "magically fixed" by simply fixing warnings.

from buildscripts.

WinterMute avatar WinterMute commented on July 27, 2024

Also moved this to the buildscripts repo where we currently manage the tools. It's not a libogc issue.

This is also likely to be closed pending an actual testcase that shows an actual bug. Working when built with one compiler and not working when built with another compiler (whether that be a different gcc version or clang or any other random compiler you have access to) isn't necessarily an indication of any fault with the compiler.

from buildscripts.

PsiLupan avatar PsiLupan commented on July 27, 2024

Turning that warning back on and adding -Wall I get a lot of warnings that really should be fixed. Implicit function definitions and may be used uninitialized are classic nasal demon triggers.

build.log

I would be massively unsurprised if fixing all those warnings made the issue go away. Can't guarantee it will but I've seen far too many problems "magically fixed" by simply fixing warnings.

Cleaned up nearly all the warnings, save for some in some unused functions. Also, specifically checked a known use of an uninitialized value for the tev coloring that the game itself does, and that didn't appear to be the culprit either.

It's not likely I'll be able to come up with a test case anytime soon, so I guess I'll go ahead and close this. I'll try to get the stack trace at some point and see where it happens. If it's in libogc, I'll bring the issue back there with more details on the nature of that.

from buildscripts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.