Git Product home page Git Product logo

Comments (3)

evelikov avatar evelikov commented on August 10, 2024

Negating BUILD_EXCLUSIVE that means we want a BUILD_REQUIRES right?

Overall I like the idea, but I'm a little concerned about:

  • conflicting configuration - doable but needs documentation and tests, which can raise the complexity
  • forward and backward compatibility - say I create a new dkms module that uses the new token and some users try it against older dkms

Latter is a bit moot point, since we don't do much of that atm. The former seems far more relevant IMHO.

from dkms.

anbe42 avatar anbe42 commented on August 10, 2024

I would see it more as BUILD_EXCLUDE, but that's visually very similar ..

I don't see a potential for conflicting configuration. All BUILD_EXCLUSIVE_* settings define some contraints, and if a kernel does not match any one of them it is thrown out.

New directives will be ignored by older dkms, we just shouldn't change the meaning of the previously existing ones ...
The modules will simply fail to build with the older dkms since it was impossible to express the constraint to exclude that kernel at that time.

from dkms.

evelikov avatar evelikov commented on August 10, 2024

I may or may not have misread "exclusive" as "exclude" in the first place 😛

Speaking of conflicting configuration, let's consider BUILD_EXCLUSIVE=5.1 and BUILD_EXCLUDE=5.*. This should result in 0 modules handled, correct? It is somewhat of a nonsensical config, so I'm wondering if that should be success, skip or failure? Do we want to inform the user about the potential typo/miss-config?

from dkms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.