Recently the CI broke in a somewhat odd manner: latest <a href

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Thanks for the links <a class="user-mention notranslate" data-hovercard-type="user" da

Inclined to merge <a class="issue-link js-issue-link" data-error-text="Failed to load

Ubuntu 22.04 VM broke about dkms HOT 6 OPEN

evelikov commented on August 10, 2024

Ubuntu 22.04 VM broke

from dkms.

Comments (6)

evelikov commented on August 10, 2024

@xnox is this of interest to the Canonical/Ubuntu team? I don't mind having a look myself, if anyone can point me to a the git repo/branch used to produce the jammy/azure variant.

Alternatively we can drop Ubuntu from the CI, although I'd rather have that as last resort.

from dkms.

xuzhen commented on August 10, 2024

The Makefile.modinst file was modified in Ubuntu.

--- linux-azure-6.5.0.orig/scripts/Makefile.modinst
+++ linux-azure-6.5.0/scripts/Makefile.modinst
@@ -24,7 +24,9 @@
 suffix-y				:=
 suffix-$(CONFIG_MODULE_COMPRESS_GZIP)	:= .gz
 suffix-$(CONFIG_MODULE_COMPRESS_XZ)	:= .xz
-suffix-$(CONFIG_MODULE_COMPRESS_ZSTD)	:= .zst
+## UBUNTU: Support, but do not require zstd compressed modules
+# Many external dkms and signing rely on uncompressed modules
+# suffix-$(CONFIG_MODULE_COMPRESS_ZSTD)	:= .zst
 
 modules := $(patsubst $(extmod_prefix)%.o, $(dst)/%.ko$(suffix-y), $(modules))

FYI:

from dkms.

xuzhen commented on August 10, 2024

It looks like only Ubuntu 22.04 (Jammy) with kernel version 6.5 or later will have this issue.

from dkms.

xuzhen commented on August 10, 2024

After further investigation, I found that this problem was actually caused by the inconsistent judgment of module compression methods between dkms and run_test.sh. dkms also checks modules.dep

dkms/dkms.in

Lines 234 to 245 in 4d466bf

 # Figure out the correct module suffix for the kernel we are currently 

 # dealing with, which may or may not be the currently installed kernel. 

 set_module_suffix() 

 { 

 # $1 = the kernel to base the module_suffix on 

 kernel_test="${1:-$(uname -r)}" 

 module_uncompressed_suffix=".ko" 

 grep -q '\.gz:' $install_tree/$kernel_test/modules.dep 2>/dev/null && module_compressed_suffix=".gz" 

 grep -q '\.xz:' $install_tree/$kernel_test/modules.dep 2>/dev/null && module_compressed_suffix=".xz" 

 grep -q '\.zst:' $install_tree/$kernel_test/modules.dep 2>/dev/null && module_compressed_suffix=".zst" 

 module_suffix="$module_uncompressed_suffix$module_compressed_suffix" 

 }

I created PR #410 for this issue.

from dkms.

evelikov commented on August 10, 2024

Thanks for the links @xuzhen

Looking through the patch and the issue at hand it doesn't seem clear to me, why devs opted for patching the kernel instead of changing the CONFIG toggle. It basically leaves the option enabled, only to patch out the functionality 🤔

@xnox @arighi any input?

from dkms.

evelikov commented on August 10, 2024

Inclined to merge #411 as a temporary workaround.

from dkms.

Ubuntu 22.04 VM broke about dkms HOT 6 OPEN

Comments (6)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	# Figure out the correct module suffix for the kernel we are currently
	# dealing with, which may or may not be the currently installed kernel.
	set_module_suffix()
	{
	# $1 = the kernel to base the module_suffix on
	kernel_test="${1:-$(uname -r)}"
	module_uncompressed_suffix=".ko"
	grep -q '\.gz:' $install_tree/$kernel_test/modules.dep 2>/dev/null && module_compressed_suffix=".gz"
	grep -q '\.xz:' $install_tree/$kernel_test/modules.dep 2>/dev/null && module_compressed_suffix=".xz"
	grep -q '\.zst:' $install_tree/$kernel_test/modules.dep 2>/dev/null && module_compressed_suffix=".zst"
	module_suffix="$module_uncompressed_suffix$module_compressed_suffix"
	}