Git Product home page Git Product logo

Comments (4)

xuzhen avatar xuzhen commented on August 10, 2024

There is already a PR for this: #415

from dkms.

wubo0067 avatar wubo0067 commented on August 10, 2024

The file name also needs to be optimized. If there are multiple -k or --all, it becomes too long, for example: i40e-2.25.9-kernel4.18.0-425.3.1.el8.x86_64-x86_64-kernel4.18.0-425.19.2.el8_7.x86_64-x86_64.dkms.tar

from dkms.

evelikov avatar evelikov commented on August 10, 2024

@wubo0067 as mentioned in the PR, do you mind adding a test so we don't re-introduce this in the future?

I'm not sure what you mean by "The file name also needs to be optimized" - if you can submit a PR that would be appreciated.

from dkms.

wubo0067 avatar wubo0067 commented on August 10, 2024

@evelikov
1: Honestly, I'm not sure what kind of tests meet your requirements. If you have examples, I can give it a try.
2: Filename optimization refers to the situation where, under -k or -all, if there are multiple kernel patch versions in the system, the generated xxx.dkms.tar filename will be very long. I want to think about how to optimize it and try to make a PR.

from dkms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.