darealshinji / sonic-4-launcher Goto Github PK

The latest release (r3) is detected by several antiviruses including Windows Defender which automatically removes it: https://www.virustotal.com/gui/file/706703d1f4d8f35376886d988511658e7369a41183a4609138f6514550a0987d/detection

Is there any specific reason for this happening, I know you changed the code to add 'memset' but what exactly is the point of adding that if it just gets flagged as malware? I wanted to add this launcher to PCGamingWiki as an alternative to installing Java, but I can't do it unless this issue is addressed/explained.

So I did an examination on the original Java launcher for Sonic 4 - Episode 1 and it turns out the resolution options are NOT hard-coded, which means it is possible to play it at higher resolutions like 1440p or 4K. However, looking at the code, it seems you chose to hard-code the resolution options to a maximum of 1080p:
https://github.com/darealshinji/sonic-4-launcher/blob/master/src/configuration.cpp

My question is whether or not it would be possible for you to code in a way for your launcher to detect all available 16:9 resolutions based on the current monitor being used. I know this might be something difficult to implement, and sadly I don't have that much experience in coding, so I don't know how exactly I could implement this. If you or anyone else would be willing to implement this though that would be great since it is definitely possible to play Sonic 4 at 4K natively using a fixed executable (despite it saying it only upscales it to 1080p, it does indeed work for higher resolutions): https://community.pcgamingwiki.com/files/file/584-sonic-the-hedgehog-4-episode-i-1080p-fix/

This problem doesn't exist in r3.
Tested on Linux and Windows.