Comments (6)
A friend of mine compiled the launcher on Linux using "g++-mingw-w64-i686" and the executable seems to come up much cleaner in VirusTotal and works just fine: https://www.virustotal.com/gui/file/dd228dcdbea6aaf2a76f385d04a049eed65a4e6cbafae9f7477ec86c169f7726/detection
I will probably recommend people using this one since the other one will not work by default due to Windows flagging it as malware.
SonicLauncher.zip
from sonic-4-launcher.
I thought using memset()
was "smarter" than using SecureZeroMemory()
but I can simply revert it. I really don't see how using memset()
turns it into malware, but okay...
PS: Honestly, I really don't know why AntiVirus software is making so much false positives when they try to analyze binaries made with Mingw.
from sonic-4-launcher.
My friend just recompiled the latest source code as well as the previous commit that used memset and both of the executables came out the same on VirusTotal, so I think the real issue here was that the way you compiled r3 was probably done in a way Windows didn't like and flagged it for some reason, it's strange, I think I'll just close this issue, but thanks for responding. I have another issue I'd like to address soon anyway.
from sonic-4-launcher.
I have compiled it again and I get 5 warnings for the Visual Studio build and 2 warnings for the GCC build:
https://www.virustotal.com/gui/file/2dc0dc40afb3df2e23c36969699a1379f2a3bffed46a63757c7ac4272334a475/detection
https://www.virustotal.com/gui/file/7fbe125aa973842f722140eed90dc25766f2ac8eb76e5b97ad9b73d052032524/detection
I also see that the binary made by your friend is quite bigger than the one I created. Can your friend tell you how they created the binary so I could include those changes here? That would be quite helpful.
Otherwise if it can't be helped you may have to point users to a guide on how to compile the launcher themselves.
from sonic-4-launcher.
how they created the binary
Here's the instruction to build it:
sudo apt install gcc-mingw-w64-i686 g++-mingw-w64-i686
git clone https://github.com/darealshinji/sonic-4-launcher
cd ./sonic-4-launcher
git submodule init && git submodule update
make
The binary mentioned in the first comment was built on Ubuntu 16.04. The others were compiled on Xubuntu 18.04 and they have the same size as the r3's binary.
No code changes were made.
from sonic-4-launcher.
The binary provided by icup321 was 1.7 M uncompressed, the r3 binary is ~900k. Must be some version differences in the mingw packages I guess. Anyway, I guess as long as one of the builds doesn't false-positive trigger Windows Defender it's fine.
from sonic-4-launcher.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sonic-4-launcher.