dapphub / ds-token Goto Github PK
View Code? Open in Web Editor NEWA simple and sufficient ERC20 implementation
Home Page: https://dapp.tools/dappsys/ds-token.html
License: GNU General Public License v3.0
A simple and sufficient ERC20 implementation
Home Page: https://dapp.tools/dappsys/ds-token.html
License: GNU General Public License v3.0
Hi, Is there any plan to support ERC223?
test issue
symbol & name of the token should be defined as a string, but you defined as byte32, which breaks the erc20 interface.
so when I use the standard erc20 interface to unpack dstoken, I get errors
abi: cannot marshal in to go slice: offset 35000214728014336407470934256024915466671168103574785725052718905953538277408 would go over slice boundary (len=32)
you can refer to this token contract(mkr): https://etherscan.io/address/0x9f8f72aa9304c8b593d555f12ef6589cc3a579a2#code
I compiled with solc:0.5.12
successfully and failed to run dapp create
with nor string or bytes32
it shows the error:
hevm: could not parse abi argument: 0x494f550000000000000000000000000000000000000000000000000000000000 : string
I was about to do a pull request with fixed contract paths that I noticed some contracts such as auth.sol
is missing from the files.
some other contracts have wrong paths, e.g /token/
and /data/
directories
import 'auth.sol';
import 'token/controller.sol';
import 'token/event_callback.sol';
import 'token/token.sol';
import 'auth.sol';
import 'data/approval_db.sol';
import 'data/balance_db.sol';
import 'token/erc20.sol';
import 'token/event_callback.sol';
import 'token/frontend.sol';
import 'token/token.sol';
import 'util/safety.sol';
I'm wondering if the use of the words 'debit' and 'credit' in the definitions of 'mint' and 'burn' are intentionally used in the technical accounting sense of the term or not. The current wording implies that accounts are credit-normal (like a liability) and the total supply is debit-normal (like an asset). If that's the case, I think that that should be made explicit in the readme and the verbiage on
Lines 18 to 24 in 13e0934
#### `mint`
increase (credit) tokens at an address whilst simultaneously increasing (debiting) `totalSupply`
(requires auth)
#### `burn`
decrease (debit) tokens at an address whilst simultaneously decreasing (crediting) `totalSupply`
(requires auth)
start -> flow
stoppable -> stops, make ds-stops
approve -> ?
transfer -> handled by push
transferFrom -> move
, also pull
for natural case
(keep erc20 names for compatability. ew!)
I think there's an edge case: INT_MIN/-1
What is the supported solc version?
I'm sure I'm doing something wrong... but not sure what.
Trying to compile token.sol and it fails at the import statements.
The website link on this repo (https://github.com/dapphub/ds-token) is broken. We link out to this page from the ethereum.org developer docs. Could you confirm the status of this project?
Line 36 in cee36a1
Hi,
The function DSToken.transferFrom
emits an event Transfer
, which is not documented in the README doc.
Line 80 in 16f187a
A potential fix could be adding "Emits a Transfer
event" to the README doc.
Furthermore, function DSToken.transfer
calls the function transferFrom
. So it also emits the event Transfer
.
Line 63 in 16f187a
A potential fix could be also adding "Emits a Transfer
event" to this function in the README doc.
Could you please check it?
Thanks.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.