Git Product home page Git Product logo

Comments (5)

nmushegian avatar nmushegian commented on August 21, 2024 1

@stevenh512 Take a look now - you'll see there is still some spaghetti since subpackages and subdirectories are indistinguishable instead of following the "./localdir" vs "package/" convention, but at least now everything is there and a pull + submodule update should give you something that passes all tests

from ds-token.

nmushegian avatar nmushegian commented on August 21, 2024

dapple submodules are just git submodules but you still have to do it manually, git submodule --init --recursive update

it's strange that I missed the bad import paths, I could have sworn I pushed a version that passed all tests. will investigate

from ds-token.

stevenh512 avatar stevenh512 commented on August 21, 2024

The biggest problem I see, is that I don't see any ds-data or ds-util repositories on GitHub. If you have a version of this that passes all tests, I'm guessing those repositories probably exist. Maybe they're not public for some reason?

There are also no submodules (git submodule update --recursive --init doesn't do anything) and a few include paths need to be adjusted (auth.sol -> auth/auth.sol, token/erc20.sol -> erc20/erc20.sol, token/controller.sol -> controller.sol, etc).. but even if you didn't already have a version that passes all tests, those would be trivial things to fix with a pull request if there were public ds-data and ds-util repositories.

from ds-token.

nmushegian avatar nmushegian commented on August 21, 2024

For context, I'm right in the middle of pulling these out of here: https://github.com/nexusdev/dappsys/tree/develop/contracts

If you're getting this into it, I suggest to go ahead and use that package for development. These fragmented subpackages are also going to be turbulent as we transition to dapple v0.8 which has a backwards incompatible package/dappfile format.

from ds-token.

nmushegian avatar nmushegian commented on August 21, 2024

also now I think this repo should have its own datastore contract definition, not sure about hoisting util or not since it is very much in flux and we just use a few safe math functions

from ds-token.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.