Should listener.failure be called when the circuit is closed and a call fails? about pybreaker HOT 10 CLOSED

Good catch.

AFAIK this behavior is not intentional, seems more like a bug to me.

from pybreaker.

Just pushed a new version, that hopefully fixes this issue, can you take some time to test it?

from pybreaker.

Sure, all my tests pass at the moment but it's still fairly early in my development process.

from pybreaker.

Actually, it looks like Redis is now a dependency, it wasn't before. If that was intentional, that's fine. Otherwise, my tests are now broken.

from pybreaker.

Redis is an optional dependency, in case you enable the Redis backing. You should be able to use it without it though.

from pybreaker.

I get ImportError: CircuitRedisStorage can only be used if the required dependencies exist as soon as I import pybreaker, using Python 3.6.

from pybreaker.

This is a bug; redis should not be required to use pybreaker.

I'll see what I can do. /cc @phillbaker

from pybreaker.

Ouch. Sorry about that. I'll take a look tonight.

from pybreaker.

@sj175 can you please try 0.3.3 to see if the last PR fixes the issue? Feel free to reopen this in case it didn't.

from pybreaker.

That's fixed. Brilliant, thank you!

from pybreaker.