Comments (3)
danielfm
commented on August 16, 2024
1
The failure which passes the fail threshold throws a CircuitBreakerError instead of the actual underlying exception. To me, this is semantically incorrect. A real error happened, and the circuit was not bypassed, so why are we showing a CircuitBreakerError?
It makes sense, although the current behavior might also be relied by many projects, so changing this behavior might fix your case, but might break others.
If you agree to allow this behavior to be customized via some option, and to keep the current behavior as-is, I don't see any problems with accepting a PR for improving this use case.
from pybreaker.
Cruuncher
commented on August 16, 2024
@danielfm Is something like this how you had in mind for it to be configurable? I can edit it if you have a better idea
from pybreaker.
danielfm
commented on August 16, 2024
Yes, thanks for the contribution!
from pybreaker.
Related Issues (20)
- proposal: adding a name property to CircuitBreaker HOT 1
- Chaining exception into the CircuitBreakerError HOT 2
- New release HOT 1
- Is the lock effective even across multiple server processes?
- Allow installing CircuitBreakerStorageBasedTestCase as a pip extra
- Exceptions in generators have wrong location
- Old versions of Python
- Python 3 support HOT 5
- Performance issues for multithreading
- Monitoring two or more funcions HOT 1
- Maintainership HOT 1
- TTL on Redis HOT 1
- pybreaker should provide getter for the time remaining till the circuit changes state from open to half-open
- README sentence left hanging HOT 2
- Missing py.typed Marker HOT 3
- Contextmanager / `with` API? HOT 2
- define two CircuitBreaker problem HOT 1
- (🐞) incorrect typing for exclude argument HOT 7
- Async support and fallback function support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pybreaker.