(🐞) incorrect typing for exclude argument about pybreaker HOT 7 CLOSED

Thanks for the report. Would you be willing to submit a pull request to fix the issue?

from pybreaker.

I'll give it a try...

from pybreaker.

pre-commit is giving errors :(

I could modernise the python setup like this, guaranteeing reproducible builds. This would also relieve potential contributors from having to manually install tools like pre-commit, black, etc., and they can't forget to run pre-commit install anymore.

Would consider such a pull request?

from pybreaker.

Sure, that would be awesome!

from pybreaker.

I created a draft PR that sets up tooling and fixes the type hints, but I suggest to take it further:

• add ruff for static code analysis (and use it as replacement for black and isort)
• use pytest to simplify test code and type check the test code so that typechecks.py can be removed again
• use pyproject.toml for project meta instead of setup.py

These changes would require python >=3.8, meaning that 3.7 can't be tested anymore (although the lib can still be used with 3.7)
Let me know what you think of it

from pybreaker.

I'm okay with dropping support for py3.7.

from pybreaker.

finished the PR:

• successful build
• successful publish to test pypi
• you can publish to pypi with ./pw flit publish using settings from ~/.pypirc

from pybreaker.