Comments (3)
Hey @phillbaker!
Like you said, I'd prefer if such a feature is completely optional.
We could do this by detecting if the required dependencies for some particular storage backend are installed (instead adding these dependencies in setup.py
for everybody), kinda like we usually do when dealing with deprecated modules:
# In the module that implements the Redis-based persistence factory, or whatever
try:
import dependency
except ImportError:
# Module does not exist, so this feature is not available
# Raise an error explaining this could only be used if the required dependencies exist
As for the implementation, all I can say is to keep it as simple as possible. It sure looks the implementation in breaker_box is simple enough, so that's fine by me.
from pybreaker.
One more thing is that you need to be careful so that any problems communicating with the storage backend do not interfere with the circuit breaker (and thus not cause application errors) if the storage is offline.
from pybreaker.
Thanks! I'll see where we end up and if it makes sense to PR back to this repo. Thanks for the work on this!
from pybreaker.
Related Issues (20)
- Error thrown when state is missing on Redis HOT 1
- proposal: adding a name property to CircuitBreaker HOT 1
- Chaining exception into the CircuitBreakerError HOT 2
- New release HOT 1
- Is the lock effective even across multiple server processes?
- Allow installing CircuitBreakerStorageBasedTestCase as a pip extra
- Exceptions in generators have wrong location
- Old versions of Python
- Python 3 support HOT 5
- Performance issues for multithreading
- Monitoring two or more funcions HOT 1
- CircuitBreakerError hiding a real ConnectTimeout HOT 3
- Maintainership HOT 1
- TTL on Redis HOT 1
- pybreaker should provide getter for the time remaining till the circuit changes state from open to half-open
- README sentence left hanging HOT 2
- Missing py.typed Marker HOT 3
- Contextmanager / `with` API? HOT 2
- define two CircuitBreaker problem HOT 1
- (🐞) incorrect typing for exclude argument HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pybreaker.