Git Product home page Git Product logo

dtlcitizenstrader's People

Contributors

chasingcode avatar dandielo avatar ellelaith avatar nyanna avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

dtlcitizenstrader's Issues

Critical Bug (Breaks Traders Completely)

When switching tabs in management mode, i.e. from price to stock, there is sometimes this horrible bug where a certain item in the NPC will copy itself to the first available slot in the NPC inventory.

If there is more than one stack of that bugged block / item, it will reproduce either a full or half stack, plus 1. The rest will be missing. Other times, it will copy itself and leave part of the stack of the original in place.

Also, if you have a price set on a bugged item before it bugs, it will permanently list the price as "pattern price" after the bug happens.

If you remove the bugged item stacks and try to put fresh ones in, they just start the replicating problem all over.

However, you can still purchase bugged blocks / items from the NPC without issue.

When this happens, the trader becomes irrevocably and indefinitely broken and you have to make a new one from scratch.

Can't change prices?

Hi,

I'm currently trying to set up a simple block trader, I'm not able to change the prices, right and left clicking both show price: 0.

Invisible items

Items that a player can't buy won't show up in the traders window

Renaming NPCs can cause stock loss

If you make an NPC, and put things into its sell or buy windows, and re-name that NPC any time after items have been added, the resultant NPC has an empty shop window, and items have to be re-added. Before today, we had no problem re-naming NPCs after their shops were set up.

Banker types

Finish the bankers so they can be used on servers

Strage behavior

Hello there,

I got some strange behavior... I can configure the trader, but when I get out the server and login again, the trade windows won't appear anymore, I need to call /citizens reload, so I can rightclick again..

Music Discs Not Retaining Price

We have found that music discs do not work with traders, at least on our server. Putting them in a shop and setting prices on them works fine, but a few hours later (possibly after each server restart?), they are once again set at $0.

bug

If server stop's Prices don't save on any ID... Fix saving prices on server stop ( ver 1.9.6)

Using inheritance increases multiplier

I've found an interesting bug. If you inherit prices that have a multiplier, it is applied twice. If you then inherit something else, it's applied yet another time. If you ad the multiplier in the final set, it doesn't apply to the inherited.

land:
  prices:
    all:
      multiplier: 1.0
      '1': 1.0
      '3': 0.5
      '12': 0.5
      '13': 2.0
      '24': 1.5
    buy:
      multiplier: 0.8
nether:
  prices:
    all:
      multiplier: 1.0
      '87': 1.0
      '88': 2.0
    buy:
      multiplier: 0.8
test:
  inherits:
    - land
    - nether
  items:
    all:
    - 1 a:1
    - 3 a:1
    - 12 a:1
    - 13 a:1
    - 24 a:1
    - 87 a:1
    - 88 a:1

Buy multiplier ends up being 0.64 on some items

```yaml
land:
  prices:
    all:
      multiplier: 1.0
      '1': 1.0
      '3': 0.5
      '12': 0.5
      '13': 2.0
      '24': 1.5
nether:
  prices:
    all:
      multiplier: 1.0
      '87': 1.0
      '88': 2.0
test:
  inherits:
    - land
    - nether
  prices:
    buy:
      multiplier: 0.8
  items:
    all:
    - 1 a:1
    - 3 a:1
    - 12 a:1
    - 13 a:1
    - 24 a:1
    - 87 a:1
    - 88 a:1

Doesn't change a thing.

Patterns Durability Question

Hey Dandielo!

I just wanted to see if there was a simple way for me to input prices for damaged items in a pattern. If I understand how it works correctly I would need to set a d: for each single value of durability loss, which would be hundreds and thousands of lines. Is there anyway I can input the durability as an interval?

i.e. For a Diamond sword if I want 25% intervals I could do d: 1562-1172 , d: 1171-781, d: 780-391, d:391-0.

Thanks!

AND AGAIN

Some new issues by me.
For a first, creating trader with /trader create - crushing server now :D IT'S SOOOOO NICE!
For a second, it's something wrong with managing mode, I CAN'T ADD NEW STOCK ITEM'S!!
And yes, now it saving price's thanks.

Decimal Prices for Traders

Hey Dan, really liking the interface for the traders. My only qualm is that only being able to sell items at whole number prices is a little limiting, so if there were a way to increment the decimal price of an item (or even just manually enter it in), that would make this plugin that much better.

Thanks!

**EDIT: Problem was already fixed, whoopsies

Error will trying to sell to trader

I downloaded dtlTrader2.3.0.jar because of a previous issue with selling to the trader. After restarting the server when I click to trade with the NPC the following error occurs:

21:09:55 [SEVERE] java.lang.NullPointerException
21:09:55 [SEVERE] at net.dtl.citizens.trader.objects.Wallet.townyWithdraw(Wallet.java:78)
21:09:55 [SEVERE] at net.dtl.citizens.trader.objects.Wallet.withdraw(Wallet.java:179)
21:09:55 [SEVERE] at net.dtl.citizens.trader.parts.TraderConfigPart.withdraw(TraderConfigPart.java:54)
21:09:55 [SEVERE] at net.dtl.citizens.trader.parts.TraderConfigPart.sellTransaction(TraderConfigPart.java:74)
21:09:55 [SEVERE] at net.dtl.citizens.trader.types.Trader.sellTransaction(Trader.java:341)
21:09:55 [SEVERE] at net.dtl.citizens.trader.types.ServerTrader.simpleMode(ServerTrader.java:245)
21:09:55 [SEVERE] at net.dtl.citizens.trader.NpcEcoManager.onInventoryClick(NpcEcoManager.java:199)
21:09:55 [SEVERE] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
21:09:55 [SEVERE] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
21:09:55 [SEVERE] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
21:09:55 [SEVERE] at java.lang.reflect.Method.invoke(Unknown Source)
21:09:55 [SEVERE] at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:425)
21:09:55 [SEVERE] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
21:09:55 [SEVERE] at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:477)
21:09:55 [SEVERE] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:462)
21:09:55 [SEVERE] at net.minecraft.server.v1_4_6.PlayerConnection.a(PlayerConnection.java:1204)
21:09:55 [SEVERE] at net.minecraft.server.v1_4_6.Packet102WindowClick.handle(SourceFile:31)
21:09:55 [SEVERE] at net.minecraft.server.v1_4_6.NetworkManager.b(NetworkManager.java:290)
21:09:55 [SEVERE] at net.minecraft.server.v1_4_6.PlayerConnection.d(PlayerConnection.java:112)
21:09:55 [SEVERE] at net.minecraft.server.v1_4_6.ServerConnection.b(SourceFile:39)
21:09:55 [SEVERE] at net.minecraft.server.v1_4_6.DedicatedServerConnection.b(SourceFile:30)
21:09:55 [SEVERE] at net.minecraft.server.v1_4_6.MinecraftServer.r(MinecraftServer.java:598)
21:09:55 [SEVERE] at net.minecraft.server.v1_4_6.DedicatedServer.r(DedicatedServer.java:224)
21:09:55 [SEVERE] at net.minecraft.server.v1_4_6.MinecraftServer.q(MinecraftServer.java:494)
21:09:55 [SEVERE] at net.minecraft.server.v1_4_6.MinecraftServer.run(MinecraftServer.java:427)
21:09:55 [SEVERE] at net.minecraft.server.v1_4_6.ThreadServerApplication.run(SourceFile:849)

DtlTrader not working with current version of bukkit?

Hey Dandielo,

I can't get traders working at all with the following versions:

Bukkit: 1.3.2 build# 2396
Citizens2: build# 495
DtlTrader: build# 1.9.61

Here is the error I keep getting when I try to manage a brand new trader...
http://i.imgur.com/g7NMj.png

I have the correct permissions, I'm the OP anyways, but nothing....

Bankers seem to work pretty well, but I can't even set up a trader :[

I know 1.4 is coming and a big deal etc...please help, I really love this and want it to work! :]

Suggestion: /managermode Command

Hello again! I was wondering if it would be possible to activate Manager Mode for a trader with a command. Right clicking with an item stops working for me if I trait the NPC as a denizen as well. I get around it by removing the denizen trait temporarily, but would be a little more convenient/straight forward to just type something.

Error when selling and selecting NPCs

Hey there. I'm getting "Not enought money" when I try to sell something to the NPC, and when I select the NPC with a stick and type "/trader", I get this error:

2012-12-20 14:57:02 [INFO] alan issued server command: /trader
2012-12-20 14:57:02 [SEVERE] null
org.bukkit.command.CommandException: Unhandled exception executing command 'trader' in plugin DtlCitizensTrader v2.2.0 Beta
    at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46)
    at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:186)
    at org.bukkit.craftbukkit.v1_4_5.CraftServer.dispatchCommand(CraftServer.java:539)
    at net.minecraft.server.v1_4_5.NetServerHandler.handleCommand(NetServerHandler.java:999)
    at net.minecraft.server.v1_4_5.NetServerHandler.chat(NetServerHandler.java:917)
    at net.minecraft.server.v1_4_5.NetServerHandler.a(NetServerHandler.java:861)
    at net.minecraft.server.v1_4_5.Packet3Chat.handle(Packet3Chat.java:44)
    at net.minecraft.server.v1_4_5.NetworkManager.b(NetworkManager.java:290)
    at net.minecraft.server.v1_4_5.NetServerHandler.d(NetServerHandler.java:113)
    at net.minecraft.server.v1_4_5.ServerConnection.b(SourceFile:39)
    at net.minecraft.server.v1_4_5.DedicatedServerConnection.b(SourceFile:30)
    at net.minecraft.server.v1_4_5.MinecraftServer.r(MinecraftServer.java:584)
    at net.minecraft.server.v1_4_5.DedicatedServer.r(DedicatedServer.java:222)
    at net.minecraft.server.v1_4_5.MinecraftServer.q(MinecraftServer.java:480)
    at net.minecraft.server.v1_4_5.MinecraftServer.run(MinecraftServer.java:415)
    at net.minecraft.server.v1_4_5.ThreadServerApplication.run(SourceFile:856)
Caused by: java.lang.NullPointerException
    at net.dtl.citizens.trader.TraderCommandExecutor.onCommand(TraderCommandExecutor.java:82)
    at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44)
    ... 15 more

Idea - A plugin like this por personal shop

Hello there,

What you think about a plugin just like this one, but instead of NPC the player could manage one shop for when other players right click them? It would be awesome!

It could tipe some command like /selfshop then the management windows would open, then he can place the itens that he is selling and buying ๐Ÿ‘

[BUG] All commands - see /trader help error

Any of the commands possible for DtlCitizensTrader DO NOT WORK, instead they all reply back with "See /trader help for a list of commands."
When the other command is used "/help DtlCitizensTrader" it DOES return with "Below is a list of all DtlCitizensTrader commands." It shows two commands, "/banker" and "/dtlcitizenstrader:trader:".
Upon using /dtlcitizenstrader:trader it comes back with the full list of commands but again they all return with "See /trader help for a list of commands.".

My Server is running 1.4.7 R1
As for the plugins i disabled ALL of them while to narrow down the problem however it is not due to other plugins. I have started the server with just these plugins: Citizens2, DtlCitizensTrader and Vault (All latest builds).

I have used previous builds and they give me errors (to be expected) HOWEVER what they can do is execute the commands, the commands get parsed however return with errors, DtlCitizensTrader isn't even parsing the commands. Not entirely sure how other servers have gotten this working as they are running 1.4.7-R1 and work fine, i dont know what version they are running.

*Something weird that i noticed is that all the plugins extract to their appropriate folders upon server start however Vault does not, it still becomes enabled however does not have a cache/config folder. Not entirely sure if this is normal.

Hope this is fixed soon,
Poly359

do not have permission to select the buy even for op

A am the owner of the map and I can do all the commands for the /trader /npc (the basic /npc did not work until the latest build) but when I go into management mode for example on dtl trader it will allow the first selection of sell (or stock) but I can not set up a buy it says i do not have permissions to do so. in my permission folder for PEX I have myself as all permission '*' and I have even tried taking that off and listing all the permission for both citizens and dtl. This does the same thing when I try to use the cititrader plugin but on there it just will not allow me to select a block for the buy option. There are no errors that come up in the console and it says it loaded. I have tried every build for citizens2, dtl, cititrader and bukkit but nothing changes so far. I can issue all other commands under the earth but i can not get them to allow the buy. the config file is the default setup I have not changed a thing in there.

Chat messages when buying/selling

Hi, so far this is a great plugin. Keep up the good work ๐Ÿ‘

My question now is: Is there a way to display it in the chat, when a user buys/sells stuff? If yes i didn't find...

Issues with the last build

  • At the buy tab we have the text "Click to buy" instead of nothing or "Click to sell" when hovering itens.
  • In the description of the last buil I can see Beta version with prices in player inventory (when an item shows a price it can be sold) but there is no item price while hovering the inventory, just the description.
Update:

I get the prices in the inventory window when creating a new NPC, but the prices are quite strange as you can see in the pic. And the olds NPCs don't show that price at all..

http://postimage.org/image/ei8501zcn/

[Bug] Player limits not working

Problem
Player limits are not working as intended

How to reconstruct
Just create a new trader, add some stuff to buy and set the player limit to 3. Even as non-op you can buy 4, 5 or more items even though you should not be able to

Please fix this!

NumberFormatException when restarting

So i just configured all traders on my server. After the daily restart some of them were gone, the other wont work anymore.

I postet the exception on pastebin: http://pastebin.com/wsbgc3ij

As you can see, your StockItem class throws that exception, with the Double.parseDouble method. I didn't look into it, but parseDouble definetly needs some exception catching :). Seems like the problem is a common one because of a missing decimalpoint.

Suggestion

Hey Dandielo,

I know you're busy with the next update, but I was wondering if you were going to start adding your updates to dev.bukkit.org for the auto-updater. I'm not sure how it works since I know Dtl Trader is in beta, but my bukkit GUI is giving me this notification, " No source for DtlCitizensTrader v1.9.61Beta ask the Author to add it to dev.bukkit.org "

Hope all is going well, thanks!

Error messages in the server.log

[INFO] This server is running CraftBukkit version git-Bukkit-1.4.2-R0.2-1-g3d8a353-b2457jnks (MC: 1.4.2) (Implementing API version 1.4.2-R0.3-SNAPSHOT)
[INFO] [Sentry] Loading Sentry v1.2.2
[INFO] [Citizens] Loading Citizens v2.0.4-SNAPSHOT (build 566)
[INFO] [Builder] Loading Builder v0.6.2
[INFO] [DtlCitizensTrader] Loading DtlCitizensTrader v2.0RC v0.5
[INFO] [Vault] Enabling Vault v1.2.18-b229
[INFO] [iConomy] Enabling iConomy v7.0

2012-11-14 22:12:24 [SEVERE] Could not pass event NPCRightClickEvent to DtlCitizensTrader v2.0RC v0.5
org.bukkit.event.EventException
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:341)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:477)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:462)
at net.citizensnpcs.EventListen.onPlayerInteractEntity(EventListen.java:235)
at sun.reflect.GeneratedMethodAccessor106.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:339)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:477)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:462)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:1031)
at net.minecraft.server.Packet7UseEntity.handle(SourceFile:36)
at net.minecraft.server.NetworkManager.b(NetworkManager.java:282)
at net.minecraft.server.NetServerHandler.d(NetServerHandler.java:111)
at net.minecraft.server.ServerConnection.b(SourceFile:35)
at net.minecraft.server.DedicatedServerConnection.b(SourceFile:30)
at net.minecraft.server.MinecraftServer.r(MinecraftServer.java:578)
at net.minecraft.server.DedicatedServer.r(DedicatedServer.java:215)
at net.minecraft.server.MinecraftServer.q(MinecraftServer.java:495)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:428)
at net.minecraft.server.ThreadServerApplication.run(SourceFile:818)
Caused by: java.lang.NoClassDefFoundError: net/aufdemrand/denizen/Denizen
at net.dtl.citizens.trader.NpcEcoManager.onNPCRightCLick(NpcEcoManager.java:243)
at sun.reflect.GeneratedMethodAccessor109.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:339)
... 22 more

Firework Metadata Structure

Fireworks don't work with traders. If you create crafted fireworks (i.e. a creeper-shaped firework) and put them into an NPC, they turn into the default fireworks with no effects and no colors.

Command system redo

Also some improvements for commands, mostly a better messaging system and better support how to use them

Idea - Disable chat messages

With this new release it would be fine to have an option that disables the chat messages and buy with just one click. What u think?

Some items prevent users rightclick on traders

Hi

When one of my players holds the item "Shard of Minium" from ee3 mod they can nopt talk to traders, and this error gets dumped to the log.

When they drop the item all is good again.

Cheers,

2013-02-27 13:40:14 [SEVERE] Could not pass event NPCRightClickEvent to DtlCitizensTrader v2.2.5
org.bukkit.event.EventException
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:341)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:477)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:462)
at net.citizensnpcs.EventListen.onPlayerInteractEntity(EventListen.java:226)
at sun.reflect.GeneratedMethodAccessor98.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:339)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:477)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:462)
at net.minecraft.server.v1_4_6.PlayerConnection.a(PlayerConnection.java:1129)
at net.minecraft.server.v1_4_6.Packet7UseEntity.handle(SourceFile:36)
at net.minecraft.server.v1_4_6.NetworkManager.b(NetworkManager.java:291)
at net.minecraft.server.v1_4_6.PlayerConnection.d(PlayerConnection.java:122)
at net.minecraft.server.v1_4_6.ServerConnection.b(ServerConnection.java:54)
at net.minecraft.server.v1_4_6.DedicatedServerConnection.b(SourceFile:30)
at net.minecraft.server.v1_4_6.MinecraftServer.r(MinecraftServer.java:629)
at net.minecraft.server.v1_4_6.DedicatedServer.r(DedicatedServer.java:228)
at net.minecraft.server.v1_4_6.MinecraftServer.q(MinecraftServer.java:517)
at net.minecraft.server.v1_4_6.MinecraftServer.run(MinecraftServer.java:447)
at net.minecraft.server.v1_4_6.ThreadServerApplication.run(SourceFile:849)
Caused by: java.lang.ArrayIndexOutOfBoundsException: 624
at org.bukkit.craftbukkit.v1_4_6.inventory.CraftItemFactory.getItemMeta(CraftItemFactory.java:48)
at org.bukkit.craftbukkit.v1_4_6.inventory.CraftItemFactory.getItemMeta(CraftItemFactory.java:44)
at org.bukkit.craftbukkit.v1_4_6.inventory.CraftItemStack.getItemMeta(CraftItemStack.java:303)
at org.bukkit.craftbukkit.v1_4_6.inventory.CraftItemStack.getItemMeta(CraftItemStack.java:298)
at org.bukkit.inventory.ItemStack.serialize(ItemStack.java:481)
at net.dtl.citizens.trader.objects.NBTTagEditor.removeDescriptions(NBTTagEditor.java:33)
at net.dtl.citizens.trader.types.ServerTrader.onRightClick(ServerTrader.java:969)
at net.dtl.citizens.trader.NpcEcoManager.onNPCRightCLick(NpcEcoManager.java:307)
at sun.reflect.GeneratedMethodAccessor101.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:339)
... 22 more

[FeatReq] Cancelable Denizen actions

It would be nice to have some kind of Denizen action called onTraderOpen and onTraderClose, that can be cancelled.
My idea: A trader that only opens his stock when you made a quest or set a denizen-flag. I would then be able to put some CHAT messages before (like "hey you finally got XYZ, feel free to buy some stuff" or "hey, i told you i won't trade with strangers, didn't i?").

Would be nice to have :)

Items doesn't stack after a visit to a trader

Using dtlTraders v2.2.3 Beta

When someone visits a trader with items in the inventory, they seem to acquire a status of their own, refusing to stack with new items from other sources.
Some items also keep a Unit Price and/or Stack Price when you leave the trader.

I tested this with 2 stones freshly mined from a wall.
Before I visited a trader, I threw one down on the ground, then visited the traded.
I did not mouseover the remaining stone.
When I left him, and picked up the stone from the ground, the two stones refused to stack.

Hope you can take a look at this, nothing major, but kinda annoying.

(Great plugin by the way).

Using Patterns, item tooltip shows price of 0

In setting up our server's traders, we wanted to take advantage of the pattern system. While the documentation on the wiki is a bit unclear at times, I don't think what we're experiencing is normal.

Here's one of our test patterns:

test:
  prices:
    all:
      multiplier: 1.0
      '1': 1.0
      '3': 0.5
    buy:
      multiplier: 0.8
  items:
    all:
    - 1 a:1
    - 3 a:1

And here's what we're experiencing:

2013-01-09_17 34 32
2013-01-09_17 34 35
2013-01-09_17 34 38
2013-01-09_17 34 41

If you look at the screen shots, the price shows fine when hovering over the stock. However, when you hover over your own inventory, the info is zeroed out. Purchasing and selling works as expected. So really seems to be that in your code, you're not looking for the pattern price, but the one set to that trader. Since it's not defined outside of the pattern, it's zeroed.

Patterns.YML

You requested on the bukkit dev page for it so, here it is.

Blacksmith:
prices:
sell:
267: 1.5
256: 1.0
257: 2.5
258: 2.0
292: 1.5
261: 2.0
262: .25
items:
all:
- 267 a:1 s:0 p:1.5
- 256 a:1 s:1 p:1.0
- 257 a:1 s:2 p:2.5
- 258 a:1 s:3 p:2.0
- 292 a:1 s:4 p:1.5
- 261 a:1 s:5 p:2.0
- 262 a:1 s:6 p:.25

Modded items losing data on opening trader inventory

On opening a trader's inventory, either in manage mode or for regular trading, modded items in my inventory lose information/data. Industrial craft tools lose their charge, and redpower bags lose their contents.
Renamed modded items retain their names.

Possibly related to how item descriptions are changed to show price?

Running the latest version of dtlTraders, on a mcpc+ server.

Player Traders

Adding an ability for players so set their own trader with specific wallet options.
Every one should have the ability to have his own trader :P

Enchanted Books in Pattern.yml

When I place an enchanted book in a trader's item pattern, e.g.
403 se:16/1 p:100
It displays the correct enchantment when I hover the pointer over the item to buy, but after buying it and it being placed in my inventory, it's just a plain enchanted book with no enchantment stored in it.

Suggestion for Dtltrader Banker

One suggestion for the Banker of Dtltrader would be to have a multi-tab bank. Say use different color wool to represent the different tabs at the bottom of the banker display. The first tab could be used right away and the others would have to be unlocked by purchasing the bank tabs from the server economy.

Severe issue with latest dev build 1.4.5-R0.3 and DtlCitizensTrader v2.0.0

15:13:42 [SEVERE] net/minecraft/server/NBTBase initializing DtlCitizensTrader v2.0.0 (Is it up to date?)
java.lang.NoClassDefFoundError: net/minecraft/server/NBTBase
at net.dtl.citizens.trader.CitizensTrader.onLoad(CitizensTrader.java:67)
at org.bukkit.craftbukkit.v1_4_5.CraftServer.loadPlugins(CraftServer.java:232)
at org.bukkit.craftbukkit.v1_4_5.CraftServer.(CraftServer.java:205)
at net.minecraft.server.v1_4_5.ServerConfigurationManagerAbstract.(ServerConfigurationManagerAbstract.java:51)
at net.minecraft.server.v1_4_5.ServerConfigurationManager.(SourceFile:11)
at net.minecraft.server.v1_4_5.DedicatedServer.init(DedicatedServer.java:111)
at net.minecraft.server.v1_4_5.MinecraftServer.run(MinecraftServer.java:398)
at net.minecraft.server.v1_4_5.ThreadServerApplication.run(SourceFile:856)
Caused by: java.lang.ClassNotFoundException: net.minecraft.server.NBTBase
at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:34)
at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:29)
at java.lang.ClassLoader.loadClass(Unknown Source)
at java.lang.ClassLoader.loadClass(Unknown Source)
... 8 more

Can't sell to traders

My users cant sell to traders, OPs can sell, normal users cannot.
Occasionally my users can sell 1 item at a time, but then they can't, Sometimes they get a "you dont have permission" error and other times they get "someone doesnt have enough money"

no error logs.

Guild bankers

Add a new banker type, that allows "Group Leaders" to manage banks for their faction...

Error on last build and last Bukkit

I used the last dev build of Bukkit.

14:58:20 [SEVERE] Error occurred while enabling DtlCitizensTrader v2.1.1 Beta (Is it up to date?)
java.lang.NullPointerException
at net.dtl.citizens.trader.CitizensTrader.info(CitizensTrader.java:309)
    at net.dtl.citizens.trader.CitizensTrader.onEnable(CitizensTrader.java:95)
    at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:217)
    at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:374)
    at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:381)
    at org.bukkit.craftbukkit.v1_4_5.CraftServer.loadPlugin(CraftServer.java:304)
    at org.bukkit.craftbukkit.v1_4_5.CraftServer.enablePlugins(CraftServer.java:286)
    at net.minecraft.server.v1_4_5.MinecraftServer.j(MinecraftServer.java:324)
    at net.minecraft.server.v1_4_5.MinecraftServer.e(MinecraftServer.java:303)
    at net.minecraft.server.v1_4_5.MinecraftServer.a(MinecraftServer.java:262)
    at net.minecraft.server.v1_4_5.DedicatedServer.init(DedicatedServer.java:147)
    at net.minecraft.server.v1_4_5.MinecraftServer.run(MinecraftServer.java:402)
    at net.minecraft.server.v1_4_5.ThreadServerApplication.run(SourceFile:856)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.