Git Product home page Git Product logo

Comments (10)

Dandielo avatar Dandielo commented on May 29, 2024

might be a hidden bug, will try to fix this as fast as i can thanks for the info :)

P.S. Piwo ty ty?!

from dtlcitizenstrader.

Dandielo avatar Dandielo commented on May 29, 2024

Ok a fix is on jenkins, it should work :)

from dtlcitizenstrader.

elliottmb avatar elliottmb commented on May 29, 2024

Well, something seems to have gone funny. Build 100, your fix build, seems to not work. Right clicking on a trader errors to console:

15:52:53 [SEVERE] Could not pass event NPCRightClickEvent to DtlCitizensTrader v
2.3.0 Beta
org.bukkit.event.EventException
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.ja
va:427)
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.jav
a:62)
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.j
ava:477)
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.j
ava:462)
        at net.citizensnpcs.EventListen.onPlayerInteractEntity(EventListen.java:
226)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.ja
va:425)
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.jav
a:62)
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.j
ava:477)
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.j
ava:462)
        at net.minecraft.server.v1_4_6.PlayerConnection.a(PlayerConnection.java:
1096)
        at net.minecraft.server.v1_4_6.Packet7UseEntity.handle(SourceFile:36)
        at net.minecraft.server.v1_4_6.NetworkManager.b(NetworkManager.java:290)

        at net.minecraft.server.v1_4_6.PlayerConnection.d(PlayerConnection.java:
112)
        at net.minecraft.server.v1_4_6.ServerConnection.b(SourceFile:39)
        at net.minecraft.server.v1_4_6.DedicatedServerConnection.b(SourceFile:30
)
        at net.minecraft.server.v1_4_6.MinecraftServer.r(MinecraftServer.java:59
8)
        at net.minecraft.server.v1_4_6.DedicatedServer.r(DedicatedServer.java:22
4)
        at net.minecraft.server.v1_4_6.MinecraftServer.q(MinecraftServer.java:49
4)
        at net.minecraft.server.v1_4_6.MinecraftServer.run(MinecraftServer.java:
427)
        at net.minecraft.server.v1_4_6.ThreadServerApplication.run(SourceFile:84
9)
Caused by: java.lang.NullPointerException
        at net.dtl.citizens.trader.objects.TransactionPattern.getItemPrice(Trans
actionPattern.java:225)
        at net.dtl.citizens.trader.types.Trader.getPrice(Trader.java:564)
        at net.dtl.citizens.trader.types.Trader.loadDescriptions(Trader.java:586
)
        at net.dtl.citizens.trader.types.ServerTrader.onRightClick(ServerTrader.
java:978)
        at net.dtl.citizens.trader.NpcEcoManager.onNPCRightCLick(NpcEcoManager.j
ava:342)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.ja
va:425)
        ... 23 more
>

from dtlcitizenstrader.

Dandielo avatar Dandielo commented on May 29, 2024

sry my bad xd try the next one, 99% it will work :D

By the way, tell me which sections on the wiki i should change/update to make it more clear.

from dtlcitizenstrader.

elliottmb avatar elliottmb commented on May 29, 2024

Ok, build 101 works. However, if you buy an item for the first time, it's lore is still 0, 0. Leave the trader's screen, come back, it's correct. Tells me it's not being set if you don't already have it in your inventory when coming to the trader.

And as far as the wiki goes, for patterns I'd show the an example 'global_prices'. Also, explain in the examples what the

1: 0.33
2: 0.66

means.

from dtlcitizenstrader.

Dandielo avatar Dandielo commented on May 29, 2024

ok :) going to add this hmm, abd but an item like but and then check it's price? without leaving the trader screen?

from dtlcitizenstrader.

elliottmb avatar elliottmb commented on May 29, 2024

Say we have a Trader selling/buying dirt and sand. You goto the trader with dirt in your inventory, but no sand.

  1. Open the trader screen
  2. Hover over your dirt, It will show the correct price
  3. Buy some sand
  4. Hover over your newly bought sand, It will show the price as 0
  5. Leave the Trader screen
  6. Open it again
  7. Hover over your sand, It will show the correct price

from dtlcitizenstrader.

elliottmb avatar elliottmb commented on May 29, 2024

Accidentally hit close and comment instead of comment. My bad. Refer to previous comment.

from dtlcitizenstrader.

Dandielo avatar Dandielo commented on May 29, 2024

ok thanks for that info :) fix incoming and then going to bed :P

Ok, fix is available :)

from dtlcitizenstrader.

elliottmb avatar elliottmb commented on May 29, 2024

Fixed, mate. Thanks.

from dtlcitizenstrader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.