RotateShoulderUp calculation appears incorrect when forwardDistanceRatio is negative and distinctShoulderRotationLimitBackward is not 0 about vrarmik HOT 4 OPEN

Hi! Thanks for the great analysis. That is indeed a bug which I simply did not find, probably since I did not allow the shoulders to move backwards. Does removing the "-" sign resolve the issue? I'd be happy to merge a pull request :)

from vrarmik.

Yes I think it would, but I don't have a way to test it. Just saw the issue while I was reading and wanted to make sure to mention it!

If it were me I'd probably rewrite this section to unify the if statements with something along the lines of:

float forwardDistanceRatio = Vector3.Dot(handShoulderOffset, shoulder.transform.forward) / armLength;
float upwardDistanceRatio = Vector3.Dot(handShoulderOffset, shoulder.transform.up) / armLength;

( float distanceRatioThreshold, float shoulderRotationMultiplier ) = 
	( 0 < forwardDistanceRatio 
		? ( 0.5f, distinctShoulderRotationMultiplier )
		: ( 0.08f, distinctShoulderRotationMultiplier * 10.0f ) );

forwardDistanceRatio = 
	Mathf.Sign(forwardDistanceRatio) *
	Mathf.Max(0.0f, Mathf.Abs(forwardDistanceRatio) - distanceRatioThreshold );

targetAngle.y = 
	Mathf.Clamp(
		forwardDistanceRatio * shoulderRotationMultiplier, 
		-distinctShoulderRotationLimitBackward, distinctShoulderRotationLimitForward);

But that's more than just a simple bug fix, and I'm not 100% sure if that is correct C# syntax or not!

from vrarmik.

I actually ended up writing this section totally differently in my port. I decided to just scale the distance ratio into [0,1] based on a threshold range for each direction, apply a EaseInOutSine to the resulting alpha to make it feel more organic, and then multiply it by the maximum rotation in whatever direction it's supposed to be going. A bit easier to tune for my purposes.

from vrarmik.

Thanks for your contribution.
I agree that EaseInOut would make it more organic. I hope I will be able to try these changes on a VR headset in the near future and to update the repository. Unfortunately, this project is not actively maintained and I am not developing in VR/Unity anymore.

from vrarmik.