cybozu / duck Goto Github PK

I think it's the time that we release v1. What do you think?

Remove the deprecated --dependency_mode STRICT and LOOSE, which are synonyms for PRUNE and PRUNE_LEGACY, respectively.
google/closure-compiler@0c8ae0e

After the next stable version of closure compiler, the current code will throw an error.

https://github.com/teppeis/duck/blob/47dba8fb2332b4bb617c37663eefe1343f6f812e/src/compiler.ts#L91-L94

Also see [`examples/chunks`](examples/chunks).

examples/chukns link in duck build section of README leads to 404 page.

Closure Templates requires either soyOptions.outputDirectory or soyOptions.outputPathFormat.
clean:soy and build:soy --watch commands work with outputPathFormat but throw errors for deleting soy files with outputDirectory option.

$ duck clean:soy -n
[18:03:17] Clean up soy.js [started]
[18:03:17] Clean up soy.js [failed]
[18:03:17] → Cannot read properties of undefined (reading 'replace')
TypeError: Cannot read properties of undefined (reading 'replace')
    at Object.cleanSoy (node_modules/@cybozu/duck/lib/commands/cleanSoy.js:17:10)
    at node_modules/@cybozu/duck/lib/cli.js:301:45
    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
  context: [Object: null prototype] {}
}

faastjs v3 depends on webpack v4 that does not support Node.js v17+

• nodejs 17: digital envelope routines::unsupported · Issue #14532 · webpack/webpack
• add wasm md4 implementation by sokra · Pull Request #14584 · webpack/webpack

[email protected]+ supports Node.js v17+.
To use [email protected]+, we need to update faastjs to v5.4.2+ (faastjs/faast.js@ef9968a)

Error detail:

See https://github.com/cybozu/duck/runs/7623057363?check_suite_focus=true#step:6:40

> duck build --batch local -n

[01:30:32] Compile Soy templates [started]
[01:30:32] Compile Soy templates [skipped]
[01:30:32] Generate deps.js [started]
[01:30:32] → Analyzing dependencies
[01:30:32] → Generating deps.js
[01:30:32] → Generated: /home/runner/work/duck/duck/examples/build-and-serve/build/deps.js
[01:30:32] Generate deps.js [completed]
[01:30:32] Compile JS files [started]
[01:30:33] → Initializing batch mode
Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:71:19)
    at Object.createHash (node:crypto:133:10)
    at module.exports (/home/runner/work/duck/duck/node_modules/webpack/lib/util/createHash.js:135:53)
    at NormalModule._initBuildHash (/home/runner/work/duck/duck/node_modules/webpack/lib/NormalModule.js:417:16)
    at handleParseError (/home/runner/work/duck/duck/node_modules/webpack/lib/NormalModule.js:471:10)
    at /home/runner/work/duck/duck/node_modules/webpack/lib/NormalModule.js:503:5
    at /home/runner/work/duck/duck/node_modules/webpack/lib/NormalModule.js:358:12
    at /home/runner/work/duck/duck/node_modules/loader-runner/lib/LoaderRunner.js:373:3
    at iterateNormalLoaders (/home/runner/work/duck/duck/node_modules/loader-runner/lib/LoaderRunner.js:214:10)
    at iterateNormalLoaders (/home/runner/work/duck/duck/node_modules/loader-runner/lib/LoaderRunner.js:221:10)

Run duck serve in HTTPS to prevent mixed content.
In addition, HTTP/2 may improve performance.

In the current entryconfig json format, only directories are allowed to be written in paths in an entryconfig json file.

However, I would like to specify dependent js files explicitly so that I can find all dependent files in the config file and, moreover, I can know if there are some unexpected dependencies without changing the current source code structure.

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: undefined. Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.

Node v10 has been EOL, so we'll drop Node v10 support.
In addition, I'd like to remove v10 support add v16 as a target version of CI.

When I updated the version of faastjs v5, our builds with AWS started failing, so I've reverted the change.
But it's not good to stick with v3, so we have to update the version to the latest.
(I'm not sure whether v4 works well or not)

I don't know why at the moment, but the Test workflow sometimes fails with the following error:

/home/runner/work/duck/duck/node_modules/workerpool/src/WorkerHandler.js:207
      me.worker.ready = true;
                      ^

TypeError: Cannot set property 'ready' of null
    at Worker.<anonymous> (/home/runner/work/duck/duck/node_modules/workerpool/src/WorkerHandler.js:207:23)
    at Worker.emit (events.js:314:20)
    at Worker.EventEmitter.emit (domain.js:483:12)
    at MessagePort.<anonymous> (internal/worker.js:201:53)
    at MessagePort.emit (events.js:314:20)
    at MessagePort.EventEmitter.emit (domain.js:483:12)
    at MessagePort.onmessage (internal/worker/io.js:80:8)
    at MessagePort.exports.emitMessage (internal/per_context/messageport.js:11:10)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] build:ci: `duck build --batch local -n`
npm ERR! Exit status 1

Currently, duck build:js ignores warnings of compiling.
But we have a case that we want to get the warnings.
I have two options for this.

1. Prints warnings to stderr using console.error koba04@622e593
2. Add --strict option that treats any warnings as errors koba04@59238d9

We could combine the options, which means that if --strict option is disabled, warnings are printed to stderr.

@teppeis Do you have any ideas for this issue?

tsc throws errors with [email protected].

$ npm run build       

> @cybozu/[email protected] build
> tsc

node_modules/@types/verror/index.d.ts:31:5 - error TS2416: Property 'cause' in type 'VError' is not assignable to the same property in base type 'Error'.
  Property 'message' is missing in type '() => Error | undefined' but required in type 'Error'.

31     cause(): Error | undefined;
       ~~~~~

  node_modules/typescript/lib/lib.es5.d.ts:1023:5
    1023     message: string;
             ~~~~~~~
    'message' is declared here.

node_modules/@types/verror/index.d.ts:31:5 - error TS2425: Class 'Error' defines instance member property 'cause', but extended class 'VError' defines it as instance member function.

31     cause(): Error | undefined;
       ~~~~~


Found 2 errors in the same file, starting at: node_modules/@types/verror/index.d.ts:31

It will be resolved in next TypeScript 4.8.

See

• [@types/verror] incompatible with TypeScript 4.6 · Discussion #59093 · DefinitelyTyped/DefinitelyTyped
• Set Error.prototype.cause type to unknown (#70) by iamharbie · Pull Request #49639 · microsoft/TypeScript
• [verror]: Fix @types/verror to work with es2022.error on TS 4.8 by voxpelli · Pull Request #61199 · DefinitelyTyped/DefinitelyTyped

Introduced by #695

See https://github.com/cybozu/duck/pull/695/files

https://typescript-eslint.io/rules/no-non-null-assertion/

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• chore(deps): update dependency @types/node to ~18.19.34
• fix(deps): update dependency rimraf to ^5.0.7
• fix(deps): update dependency semver to ^7.6.2
• fix(deps): update dependency workerpool to ^9.1.2
• chore(deps): update dependency prettier to ^3.3.2
• fix(deps): update dependency execa to v9
• 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update codecov/codecov-action digest to e28ff12
• chore(deps): update vitest monorepo to ^1.6.0 (minor) (@vitest/coverage-v8, vitest)
• fix(deps): update dependency fastify to ^4.28.0
• fix(deps): update dependency pino to ^8.21.0
• chore(deps): update dependency @cybozu/eslint-config to v23
• chore(deps): update dependency eslint to v9
• chore(deps): update dependency google-closure-compiler to v20240317
• fix(deps): update dependency pino to v9
• fix(deps): update dependency pino-pretty to v11
• fix(deps): update dependency rxjs to v7
• Click on this checkbox to rebase all open PRs at once

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• fix(deps): update dependency tempy to v3.1.0

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Currently, we only run the test script on GitHub Actions, so I'd like to run the lint script as well.

cause: google/closure-library#996

npm i -D @teppeis/duck
npm ERR! code ETARGET
npm ERR! notarget No matching version found for google-closure-compiler@^v20191027.0.1.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! notarget 
npm ERR! notarget It was specified as a dependency of 'google-closure-deps'
npm ERR! notarget