Git Product home page Git Product logo

Comments (4)

teppeis avatar teppeis commented on August 18, 2024

@koba04 The two options have different purposes, so consider them separately.
Option 1 should be done.
But why do you need option 2? I think that the straight forward way is to make it an error with Compiler option jscomp_error.

from duck.

koba04 avatar koba04 commented on August 18, 2024

@teppeis Thanks!

But why do you need option 2? I think that the straight forward way is to make it an error with Compiler option jscomp_error.

Ah, that's right.
I should change warning categories to ERROR if I want to do option 2.
https://github.com/google/closure-compiler/wiki/Warnings#warnings-categories

Let's discuss option 1.

I've written a patch for this.
But I doubt that there is a better approach to this.

This patch prints warnings to stderr using console.error.
I've tried to use logger for this, but I couldn't do that because, without nonTTY mode, logger output is collapsed by listr so we can't see the warnings.

from duck.

teppeis avatar teppeis commented on August 18, 2024

@koba04 There is a tricky way through logger. --printConfig uses this way.

  1. input
  2. store
  3. output

But it's too complex and we need another solution.
I think it's enough that each command returns content and cli logic outputs it.

from duck.

teppeis avatar teppeis commented on August 18, 2024

I've pushed WIP to output warnings #296

from duck.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.