contributte / gopay-inline Goto Github PK

Spent more time than I'd be willing to admit on this.

There is a wrong info in README.md regarding the installation:

composer require contributte/gopay-inline

Packagist does not know such a package, but the error given by composer is not very helpful:

Could not find a matching version of package contributte/gopay-inline. Check the package spelling, your version constraint and that the package is available in a stability which matches your minimum-stability (stable).

Finally, I've noticed the correct installation command is:

composer require markette/gopay-inline

Documentation has it right, it's just the README that's incorrect.

It is not issue, but I don't now how to solve when I have negative cents rounding (in czech "Haléřové vyrovnání"). Because it's not possible to send negative value to gateway.

Eshop owner don't want to turn off cents rounding for payment by card.

When I try to add product with price -0,30 Kč:

Guys, any idea?

Hello,

I think the argument $data in PaymentFactory::create() should be Entity because when I upgrade this package to a new version, it can make BC break.

Real log:

This error can not be inspected by PhpStan, because array is too common a data type.

If it make sense I can send PR.

Thanks.

There should be total price of items in an payment.items.amount according to the GoPay documentation. For the example we have an item ITEM1 with price 50, so I'd created the following array
$paymen = [ ...,
'amount' => \Money\Money::CZK(100),
'items' => [ [ 'name' => 'ITEM1', count => 2, 'amount' => \Money\Money::CZK(100) ] ]
]

In this example the following validation error raises "Payment price (100) and items price (200) do not match".
I think this package counts with item's amount only for 1 piece.

For stores having different tax rates (option B in GoPay doc.)
https://help.gopay.com/cs/tema/propojeni-do-eet/jak-bude-fungovat-napojeni-gopay-do-eet#varianty

It is necessary to implement object EET (added to REST API):
https://doc.gopay.com/cs/#eet

VAT rate list:
https://doc.gopay.com/en/#vat_rate

Are you planning to implement EET?

I want to upgrade to PHP 8.1, but contributte/gopay-inline requires moneyphp/money version ^3.3. This 3 version is not compatible with PHP 8.1 but version 4 is.

Here are BC breaks in moneyphp/money library version 4: https://github.com/moneyphp/money/blob/efe904ab6109d87046eb624d5dff7d270fd0cca5/CHANGELOG.md#400---2021-05-17

Is it possible to allow version 4?

Thank you for you reply ;-)

Payment uses float to store the amount, which is a rather unfortunate choice. How about using amount in cents as integer, or string or proper money object, because even integers are vulnerable to e.g. overflowing (in theory, that is)?

Btw GoPay docs says to send amounts in cents, but this package seems to expect crowns, which is not really documented. I was surprised when the gateway asked for 50k when I just wanted five hundred 😄

ref https://doc.gopay.com/#recurring-payment-cancellation

Some tracy panel for easy debugging requests to gopay.

In this version, I miss getAccountStatement() function to call this: https://doc.gopay.com/cs/#generov%C3%A1n%C3%AD-v%C3%BDpisu-obchodn%C3%ADho-%C3%BA%C4%8Dtu

Hi,
according to the gopay documentation, it goes this way.

$encryptedSignature = GopayHelper::encrypt(
                      GopayHelper::hash(
                      GopayHelper::concatPaymentCommand($targetGoId,
                                                        $paymentSessionId,
                                                        $secureKey)
                                                     ), $secureKey);	

But the data that my response returns is

'id' => 3156614799
'order_number' => 'INF252'
'state' => 'CREATED'
'amount' => 605
'currency' => 'CZK'
'payer' => stdClass
'target' => stdClass
'recurrence' => stdClass
'additional_params' => array
'lang' => 'cs'
'gw_url' => 'https://gw.sandbox.gopay.com/gw/v3/4e26c514484f8c7fd08f45177aa503c4'

So what is the procedure for creating a signature? Because I didn't find any solution anywhere.

Thx

Payment requires callback key with return_url and notify_url.
RecurrentPayment on the other hand does not allow callback key at all and is therefore incompatible.

I believe that correct configuration for both payment types should look like:

$payment = [
    .....
    'callback' => [
        'return_url' => 'http://www.myeshop.cz/api/gopay/return',
        'notify_url' => 'http://www.myeshop.cz/api/gopay/notify',
    ],
    .....
]

• move docs to .docs folder
• create makefile
• apply phpstan
• apply coding standards

prev: #50

Are there any plans to support Nette 3?

Right now, there is a depreciation warning when used with Nette 3.

PHP User Deprecated: Service gopay.client: Nette\DI\Definitions\ServiceDefinition::setClass() second parameter $args is deprecated, use setFactory() in .../src/DI/Definitions/ServiceDefinition.php:47

Pokud pro vytvoření objektu Markette\GopayInline\Api\Entity\Payment použiji PaymentFactory a v poli itemu definuji klíče vat_rate a type, ve výsledném objektu budou mít hodnotu NULL.

Rychlou analýzou odhaduji, že problém je v PaymentFactory na ř. 132 v chybné definici mapovacího pole. Pokusím se opravit.

• change namespace
• change badge URL
• apply contributte's codesniffer/phpstan/
• min PHP 7.2 (just idea)

Do API přibyla nová funkce - refundace platby vč. eet:
https://doc.gopay.com/cs/#refundace-platby-(storno)24
Potřeboval bych tuto funkčnost přidat do GopayInline

What about transfer this repo under Markette?

@vojtech-dobes
@hrach

Při nastavení klíče $payment['eet'] podle README.md a následném zavolání funkce

PaymentFactory::create($payment)

je vytvořen objekt Markette\GopayInline\Api\Entity\Payment

Ten má hodnotu atributu ["eet":protected]=>NULL

Rychlý odhad: v PaymentFactory.php chybí setter pro objekt eet, jdu se pustit do podrobnější analýzy.

Hello,
I would like to have BITCOIN account regarding latest GoPay docs
https://help.gopay.com/cs/tema/integrace-platebni-brany/technicky-popis-integrace-platebni-brany/technicke-parametry-platebnich-metod

For example error "AUTH_WRONG_CREDENTIALS" has not $field. And this is reason why exception is "Undefined property: stdClass::$field". This error is not helpful.

Hi,

authorization token is valid only 30 minutes and after that it throws exception. I tried to find any method like $client->reAuthenticate() or something like that but it doesn't exists. Or maybe put any auto revalidation before expiration. (this issue is made from slack conversation on PéHáPkaři).

Thank you.

Please take a look at:

• README: https://github.com/contributte/monolog/blob/b521d0329faa4e6ea3dc7e97eff9de4deb09e748/README.md
• Makefile (instead of composer scripts): https://github.com/contributte/monolog/blob/b521d0329faa4e6ea3dc7e97eff9de4deb09e748/Makefile
• Editorconfig: https://github.com/contributte/monolog/blob/b521d0329faa4e6ea3dc7e97eff9de4deb09e748/.editorconfig
• gitignore: https://github.com/contributte/monolog/blob/b521d0329faa4e6ea3dc7e97eff9de4deb09e748/.gitignore
• gitattributes: https://github.com/contributte/monolog/blob/b521d0329faa4e6ea3dc7e97eff9de4deb09e748/.gitattributes

Potřeboval bych rozšířit funkčnost o podporu volání této API funkce:
https://doc.gopay.com/cs/#eet-%C3%BA%C4%8Dtenky-platby

Funkce vrátí seznam všech EET účtenek k dané platbě.

Při refundaci platby přes API totiž notifikace o refundaci obsahuje EET kódy k původní platbě (podle podpory Gopay feature, nikoliv bug) a automatický email, který jde zákazníkovi, žádné EET kódy neobsahuje! (opět ověřeno na podpoře)

Je přitom povinností poplatníka kódy zákazníkovi sdělit i v případě stornované platby, jak vyplývá z § 7, zákona č. 112/2016 Sb.