Wrong type used for price amounts about gopay-inline HOT 8 CLOSED

Well, I agree. 😃

Could you prepare PR with some changes?

from gopay-inline.

Sure. What do you think would be the best approach? To kill both birds with one stone, I'd go for amount in cents as integer, but that would obviously be a huge BC break 😟 string, on the other hand, would require some math library, because the item price is multiplied by its quantity at some point

from gopay-inline.

This got me too. I would stick to the documentation = cents, integer. Differences make for surprises. But yes, BC is an issue => no simple solution.

from gopay-inline.

Personally I would like to have a Money object. We can prepare it for v2.0. Could you do that guys? @jiripudil @BayerMeister ?

from gopay-inline.

I could look into it and remove all occurrences of * 100 multiplications and rounding. I'm not feeling like adding a custom Money object while there are solutions like https://github.com/moneyphp/money, but adding a new dependency doesn't seem to be a fit either.

from gopay-inline.

I think we can include moneyphp?

from gopay-inline.

Should I keep it in style without return type hints and with annotations?

from gopay-inline.

I would be fine if you do. :-)

from gopay-inline.