contasystemer / elm-menu Goto Github PK

Is your feature request related to a problem? Please describe.

rtfeldman released a new version of elm-css (17.0.1) that works with the Dark Reader extension. See rtfeldman/elm-css#542.

The bounds of elm-menu's use of elm-css are "rtfeldman/elm-css": "16.1.1 <= v < 17.0.0"

Describe the solution you'd like

I'd love a new version of elm-menu to be released with bounds including 17.0.1.

Additional context

Thank you for considering!

Is your feature request related to a problem? Please describe.
ViewConfig and UpdateConfig are used exclusively to express additional arguments to view and update respectively.
What is the point of making them into opaque types?
If it's acceptable for the API to have a function that takes the record as parameter, why can't that function be directly view or update?
What is the point of the intermediary functions viewConfig and updateConfig and related opaque types?

Describe the solution you'd like

type alias ViewConfig item =
    { toId : item -> String
    , ul : List (Attribute Never)
    , li : KeySelected -> MouseSelected -> item -> HtmlDetails Never
    , maxResults : Int
    }

type alias UpdateConfig item =
    { toId : item -> String
    , onKeyDown : Int -> Maybe String -> Maybe msg
    , onTooLow : Maybe msg
    , onTooHigh : Maybe msg
    , onMouseEnter : String -> Maybe msg
    , onMouseLeave : String -> Maybe msg
    , onMouseClick : String -> Maybe msg
    , separateSelections : Bool
    , maxResults : Int
    }

Is your feature request related to a problem? Please describe.
Currently, this package requires use with "rtfeldman/elm-css": "17.0.1 <= v < 18.0.0". elm-css 18.0.0 has been published.

Describe the solution you'd like
Ideally, I'd love extended elm-css version support: "rtfeldman/elm-css": "17.0.1 <= v < 19.0.0".

Additional context
Thank you!

Describe the bug
when trying to build a file with --debug flag, build failes.

To Reproduce
Build file with this lib.

Expected behavior
Should build correctly in debug mode

Additional context

# CallStack (from HasCallStack):
#   error, called at libraries/containers/Data/Map/Internal.hs:603:17 in containers-0.5.10.2:Data.Map.Internal