Git Product home page Git Product logo

Comments (5)

liubogithub avatar liubogithub commented on May 24, 2024

Is this fixed or not?

from nydus-snapshotter.

imeoer avatar imeoer commented on May 24, 2024

Still not, we need to consider how to implement blob GC without this annotation.

from nydus-snapshotter.

jiangliu avatar jiangliu commented on May 24, 2024

When containerd issues PREPARE command to the snapshotter, it carries information about the parent layer id.
It's possible to track all data blobs referenced by a nydus image/meta blob.

from nydus-snapshotter.

changweige avatar changweige commented on May 24, 2024

The PR #233 is fixing this.
Nydusify has already dropped the label when converting images. The only purpose of having the label is for blob cache GC.
But contained also has a GC mechanism and a single snapshot is shared between images, which means contained won't remove a snapshot if it is still referenced by another container image. So the PR safely kicks out snapshotter cache GC code and just removes the blob cache if it corresponds to a committed layer/snapshot.

In addition, it removes the label from nydus-snapshotter

from nydus-snapshotter.

changweige avatar changweige commented on May 24, 2024

Solved. The blobs list is dropped from nydus image

from nydus-snapshotter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.