chessproblem's Issues
Simplify Design
Walter William Milner Psychologically, I think it is easier to grasp. In the real game you have a board with pieces on it, and it is simple to think of that as a 2D array, with pieces (or blanks) in each cell.
Do you use strings for colour and type? Why not enums?
Сӏаџԁе Маятіи
SOLID Principles
Madhusudhan Srikkanth I have not looked at his code but I do agree that functionality or and state must not be duplicated.
But if it I a choice between storing position in a board or in pieces, then they are both not equivalent. Storing positions of pieces on a board object makes more sense because then pieces will have a single object that they can query to say for example get all valid positions for a piece. Doing this with positions stored in a piece would be messy code. Always remember the S in SOLID principles which stands for Single Responsibility Principle for each class.
Duplicate Position/pieces
Walter William Milner You duplicate data, with respect to position.
A Piece has a position with a row and column.
And the Board has a 2D array, with Pieces held at locatiosn corresponding to a row and column.
As usual when you duplicate data, you have a possibility of inconsistency. For example, at [1][1] you might have a pawn. And the pawn might claim to be at [2][2]. You could also have another picec claiming to be at [2][2]
Do you actually need the board, if each piece knows where it is? Why not just have a set of pieces?
Or, just have teh board, and do not have positions in teh Piece class.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.