codegagan / chessproblem Goto Github PK

Madhusudhan Srikkanth I have not looked at his code but I do agree that functionality or and state must not be duplicated.

But if it I a choice between storing position in a board or in pieces, then they are both not equivalent. Storing positions of pieces on a board object makes more sense because then pieces will have a single object that they can query to say for example get all valid positions for a piece. Doing this with positions stored in a piece would be messy code. Always remember the S in SOLID principles which stands for Single Responsibility Principle for each class.

Walter William Milner Psychologically, I think it is easier to grasp. In the real game you have a board with pieces on it, and it is simple to think of that as a 2D array, with pieces (or blanks) in each cell.

Walter William Milner You duplicate data, with respect to position.
A Piece has a position with a row and column.
And the Board has a 2D array, with Pieces held at locatiosn corresponding to a row and column.
As usual when you duplicate data, you have a possibility of inconsistency. For example, at [1][1] you might have a pawn. And the pawn might claim to be at [2][2]. You could also have another picec claiming to be at [2][2]
Do you actually need the board, if each piece knows where it is? Why not just have a set of pieces?
Or, just have teh board, and do not have positions in teh Piece class.

Сӏаџԁе Маятіи