clearlinux / make-fmv-patch Goto Github PK

If one envisages using the FMV patch generator as part of CMake (or any other build process), it would be of benefit to be able to generate a single .patch file for an entire project.

With a large project, I can generate a single log.txt file yet upon using the FMV generator, I would have an output of potentially many, many patch files. It would be terrific if the patch generator had an option to generate a single .patch file:

• Easier to share a patch for a large project with ohers
• Easier to manage on a few levels (ie. no recursing through directory structures).

One concern may be that these files just may get very large, but considering that only a single line is added, this may not be a problem.

In the README.md, it would be good to elaborate on the software licensing including any restrictions placed on using this tool.

Could a representative from Intel contribute to this?

The inserted attributes prevent compilation on, for example, arm.

Wrapping the inserted line in a check for x86 platforms will preserve portability:

    ...
#if defined(i386__) || defined(__i386__) || defined(_M_IX86) || defined(_M_IX86) || defined(__X86__) || defined(_X86_) || defined(__I86__) || defined(__INTEL__) || defined(__amd64__) || defined(__amd64) || defined(__x86_64__) || defined(__x86_64) || defined(_M_AMD64)
    __attribute__((target_clones("avx2","arch=atom","default")))
#endif
    ...

Defines taken from: https://sourceforge.net/p/predef/wiki/Architectures/

I believe that the pattern matching for files in the script is limited to .c files. Could this be extended to support additional file types? Immediately, I can see inclusion of .cpp files to be of benefit.