city41 / ammister Goto Github PK

Repro:

1. open up bulk add
2. choose manufacturer: capcom
3. choose manufacturer: SNK

expected: all games in preview are made by SNK
actual: Ghouls n Ghosts is hanging out with the SNK games

4. keep changing manufacturer, GnG never goes away

Now that plans have auditing, extract that out into a common place to also audit the catalog. Audit upon launch and re-audit after an update.

Today if a file fails to download, this causes the entire update to error out and abort.

Instead, note the file failed, keep going, and report all failures at the end.

This is especially helpful for archive.org, who's servers can come and go at times.

Seems rotation in bulk add is totally broken in 0.18.0

@Eduardolicious said

 in .18 and still having issues with the new database and incorrectly selecting the filters. i.e. ROTATION = HORIZONTAL still giving tons of vertical results like arkanoid, space invaders, etc, while still also getting some horizontal titles like street fighter etc

changing to ROTATION != VERTICAL giving seemingly different results as well

Discussed in #92

https://github.com/Toryalai1/MiSTer_ArcadeDatabase/blob/main/ArcadeDatabase_CSV/ArcadeDatabase230110.csv

This db has lots of good metadata on games.

The db contains the hash for mras and rbfs, but when storing the hash, it is actually calculated from local data. This hash should be the one from the db. This is especially important from auditing, as the hash check is not very useful.

Due to Moon Patrol having cropped screenshots, AMMiSTer concludes it is a vertical game.

The short term fix is probably just whip up new screenshots. The long term fix is have a better source of truth on game metadata. Possibly there is a mame db/api out there somewhere that can be used?

In the screenshot, the plan added Finalizer a while back. Then an update pulled in new Finalizer MRAs. Since the plan is holding onto old metadata, it deems the MRA corrupt.

I have a test plan that just has all the street fighter games in a subfolder called Fighters. If I export this plan repeatedly without making any changes, every second time I run it, it deletes all the cores/roms/mras, and every other time it adds them back.

Just ran it for the 4th time:

and here's my _Arcade contents now (empty):

Today to do a bulk add for say a manufacturer, the user has to type in the name, such as "capcom". This is true of manufacturer, category, series, platform, controls and special controls.

Make them dropdowns instead, gathering all the values from the catalog.

The missing game resolver works, but is very raw.

• Clean up the styling
• give the option to auto choose games that have only one potential replacement
• Only ask to resolve games once, if they are in the plan repeatedly
• drag from catalog for resolution

In the settings panel, list out the four dbs and allow the user to toggle each one on/off.

Note: later improvement will be to allow the user to add their own dbs.

These games show missing rom, as of sync just now:

Nova 2001
Pac-Man Plus
Magical Pumpkin:Puroland de Daibouken

Building the catalog takes a long time, allow it to be canceled cleanly.

Looking at get started guide

https://github.com/city41/AMMiSTer/wiki/Getting-Started#deleting-games

I realize now that my question about the trash can in the discussions

#77

seems to be a bug. Nothing happens when I click the trash can icon.

Using Windows 11 Build 22621.1105 for all of this testing so far:

• Catalog --> Open Folder doesn't open the folder before the build catalog is made. So I don't know where the files are going to go.
• Can't cancel the build catalog action without closing the whole application.
• File --> Save Plan As... doesn't give response to the user saying that they need to build their catalog/create plan first in order to save it.
• I just downloaded the latest release, did File --> New Plan, and it tells me to "Please update first" in the msg box that pops up. Might be a misattributed response for the user since I think it means that I need to build the catalog first?
• The initial catalog build for the MRAs feels very slow, is there a way to speed it up by multiple downloads in parallel like 4-8 at a time? Just curious, I have no familiarity with anything you built this with, only electron as a user.
• For some reason, if I name a folder Favorites under my new plan, it renames it to favorites (lowercase f) when I click off of it, but when I go to rename again, it shows capital F. So I think the display of this is showing a bug:
  
  
• You might benefit from using the arcade organizer's reference DB for the metadata as there are plenty of MRA's that are outdated. @Toryalai1 has done an excellent job making a large spreadsheet of everything used in the arcade organizer script here --> https://github.com/Toryalai1/MiSTer_ArcadeDatabase/blob/main/ArcadeDatabase_CSV/ArcadeDatabase230110.csv. An example of the benefit of using his DB instead is looking at 1941, 1942, and the 1943 games and seeing how Jotego's MRA's currently don't have the category matching the typical format used by arcade-italia and mame xml's.

If an update causes an MRA to change its file name, and a plan was built with the old file name, the export will fail if the old MRA is no longer present. Even if the old MRA is still present, the newer one should be used.

When focusing on a directory with many games, the scrollbar is set on the entire window. It should only be set on the list of games, to keep the plan in view.

Requesting the ability to filter by resolutions as well, mainly for analog video output users.

It would be great for preparing folders that are compatible with my SD CRT TV, versus just using an HDMI digital display, versus using a 31kHZ CRT, etc

Can this be sped up?

A big factor is archive.org's servers are not the fastest.

Grabbing mras and cores can probably be sped up with some parallelization.

Loading a catalog takes ~3 seconds.

This is because calculating a file hash happens synchronously on the main thread. Node offers no way to do this async or on other threads. crypto-async does not work with Electron. Only solution found so far is child processes.

Surprisingly, Electron's IPC module blocks the renderer process, even when using it in "async" mode. The solution looks to be using WebSockets.

In the settings panel, give the user the option to download roms or not

When doing a bulk add, below the criteria list the games that would be added if the criteria was followed.

In the upcoming settings panel, give the user the choice between optimize speed vs optimize space

optimize speed

When exporting, export all cores and roms, regardless of what the plan says. That way from then on, exports will almost entirely be mras, making them much fater

optimize space

What the app does now. Only export exactly what is needed, and delete anything that is not in the plan.

Keep the three most recently opened plans in the file menu for easily re-opening.

Allow users to add a core they have locally by choosing the rbf and mra. From there go and get the rom if they want, and add it to the catalog in a new section.

Bonus: every update, if something looks like it is the stable version of this beta core, let the user know

Discussed in #79

When an update comes in, sometimes it changes the name of an mra file. Today that mra just comes up as missing if it was used in a plan. Add a feature for the user to resolve this better.

I added a game to the plan and exported to mister.

Then I added another game to the same plan, and exported to mister again, which caused ammister to re-copy all the rom files to the MiSTer.

Seems like a bug, unless I'm misunderstanding something.

Allow AMMiSTer to run in the system tray, and check for updates say every two hours or so. If there are some, notify the user. Of course allow the user to turn this off.

This looks to be specific to Windows.

Repo:

1. create a plan with one game in it
2. set export mode to speed
3. export to a directory
4. export to that directory again

expected: the second export should not copy rbf files
actual: rbf files are copied.

After doing an export on Windows, the export log for it is nowhere to be found. No idea why.

Seems that the other issue #84 where Space Mode was sometimes deleting on export isn't resolved. This is with 0.25.4 on Win10

To reproduce:
Open an existing plan
Go go file > new plan
the New Plan folder name can't be clicked to edit
It this didn't repro, make a subfolder in the plan, click file > new plan, proceed, and now the top level folder name will not be editable

repro isn't 100% reliable, but I can definitely get the issue to happen repeatedly

I think this is possible, but I'm not totally sure. If it is possible, add this in.

If it is possible and feasible, this might be better than the MAME idea.

After the user opens plan, remember what directory it was in and use that as the starting directory for future opens and save as's. Every time they move to a new directory, remember the new one.

The downloader looks like it can be configured to update everything except arcade games using filters. This looks promising, as AMMiSTer can just stay focused on arcade games (which is what I would prefer), and the Downloader can handle everything else.

If this works out, inform AMMiSTer users how to do this. Maybe even an option in AMMiSTer that can setup the downloader with the filter set.

So far AMMiSTer does not use file metadata in any way. This causes it to copy files needlessly just to be safe (especially MRAs, roms, and non-dated cores).

Can the file's creation/modify time be used? Is this data reliable across all the hops these files go on?

Once the Electron version is fully done and stable, port the app to Avalonia.

Why? Using Electron allowed me to create the app very quickly as it's using stuff I know very well. But Electron is bulky and wasteful. An Avalonia version should be much smaller, use far less resources, probably be faster, and still works on all major OSes.

Region is missing as a bulk add criteria. It should be a dropdown, see #14