Comments (3)
from kingdom.
Ok! Will have a look and come to you asap. Do not desperate, breakdown the problems to isolate the problem.
from kingdom.
Hi @xGauss05 @Ethanm-0371 @PauFusco
Related to this issue, I've been having a look to the branch, here are some thoughts:
- If you work with uniqueptrs, try to always work with uniqueptrs or, at least, raw pointers. Your method AddComponent accepts a reference...then you are calling the move (or copy) constructors to create a uniqueptr... too much transformations. I recommend you to accept a uniqueptr or a raw pointer:
Component* cmpptr = new Mesh(...)
void AddComponent(Component* cmpptr){
Myuniqueptrs.emplace_back(cmpptr);
}
Somethibg like this should work.
Of course, when working with smart pointers, a good practice is try to avoid "new" operator, but you can work on it later.
Btw, don't forget to implement the virtual destructor for Component!
Please, delete the copy constructors you have implemented for Texture and Mesh because they are acting as a move ctrs and it makes no sense at all. A copy ctr shoud always work with a const&:
Object(const Object& other)
from kingdom.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kingdom.