christsim / multicoin-address-validator Goto Github PK

This is my testnet address
addr_test1qr2dlzychjm4dzqfqmcsxt4ktxel5yhcpm2733s7cmjk0tcxu2hyfhlkwuxupa9d5085eunq2qywy7hvmvej456flknsqwyjd0

Motivation:

Polkadot is currently ranked 8 market cap-wise. And It's a very promising project.

Address format:

The address format used in Substrate-based chains is SS58. SS58 is a modification of Base-58-check from Bitcoin with some minor modifications. Notably, the format contains an address type prefix that identifies an address as belonging to a specific network.

For example:

Polkadot addresses always start with the number 1.
Kusama addresses always start with a capital letter like C, D, F, G, H, J...
Generic Substrate addresses start with 5.
These prefixes are defined here

Irrespective of the mode being specified, the validator returns false for muxed addresses E.G. MA7QYNF7SOWQ3GLR2BGMZEHXAVIRZA4KVWLTJJFC7MGXUA74P7UJUAAAAAAAAAABUTGI4

function getDecoded(address) {
try {
var decoded = base58.decode(address); <<<<<---------------------- this call fails
return cbor.decode(new Uint8Array(decoded).buffer);
} catch (e) {
// if decoding fails, assume invalid address
return null;
}
}

Hi! Stellar testnet address GCCVYKDNQP7NGNTR42SYPMQUZIFTPJUJHXM6JIXQMDLXMCC3ZYOV6AG3 is validated as invalid.

Steps to reproduce:

validate('GCCVYKDNQP7NGNTR42SYPMQUZIFTPJUJHXM6JIXQMDLXMCC3ZYOV6AG3', 'xlm', 'testnet') returns false

Expected behavior:

To return true

I tried to validate the tron address on the testnet, but it doesn't seem to work.
TYxNX8vuWBao85KTBsywq2Lj3h4EsgEEhF seems to be valid for all networks.

https://tronscan.org/#/address/TYxNX8vuWBao85KTBsywq2Lj3h4EsgEEhF
https://shasta.tronscan.org/#/address/TYxNX8vuWBao85KTBsywq2Lj3h4EsgEEhF
https://nile.tronscan.org/#/address/TYxNX8vuWBao85KTBsywq2Lj3h4EsgEEhF

But the code below doesn't work with testnet address validation.

var WAValidator = require('multicoin-address-validator');

var valid = WAValidator.validate('TYxNX8vuWBao85KTBsywq2Lj3h4EsgEEhF', 'tron', 'prod');
if(valid)
      console.log('This is a valid address');
else
      console.log('Address INVALID');

var valid = WAValidator.validate('TYxNX8vuWBao85KTBsywq2Lj3h4EsgEEhF', 'tron', 'testnet');
if(valid)
      console.log('This is a valid address');
else
      console.log('Address INVALID');
      
// This is a valid address
// Address INVALID

I didn't find any documents related to the differences between the testnet address and the mainnet address.
And both testnets do not recognize the address from the tests.

So, my suggestion is to change the address prefix for the testnet as it appears on the mainnet.
teke97@d31d1aa

When working with esbuild/vite we are not bundling node modules by default. This cause this library to crash with this error:

Uncaught ReferenceError: Buffer is not defined
    at node_modules/multicoin-address-validator/src/crypto/blake256.js (blake256.js:32)
    at __require (multicoin-address-validator.js?v=6adeb2e6:12)
    at node_modules/multicoin-address-validator/src/crypto/utils.js (utils.js:3)
    at __require (multicoin-address-validator.js?v=6adeb2e6:12)
    at node_modules/multicoin-address-validator/src/ripple_validator.js (ripple_validator.js:1)
    at __require (multicoin-address-validator.js?v=6adeb2e6:12)
    at node_modules/multicoin-address-validator/src/currencies.js (currencies.js:1)
    at __require (multicoin-address-validator.js?v=6adeb2e6:12)
    at node_modules/multicoin-address-validator/src/wallet_address_validator.js (wallet_address_validator.js:1)
    at __require (multicoin-address-validator.js?v=6adeb2e6:12)

Maybe the best thing to do is to import a Buffer library to be able to run on the browser without relaying on the bundlers (Like webpack)

Here's an easy way to see it in action: here
Thanks

For BSC and TRON it is showing a different error, that is "TypeError: Cannot read properties of null (reading 'validator')", even though I pass inputs, and it is not validating properly.

Uncaught ReferenceError: Buffer is not defined
at node_modules/multicoin-address-validator/src/crypto/blake256.js (blake256.js:32)
at __require (multicoin-address-validator.js?v=6adeb2e6:12)
at node_modules/multicoin-address-validator/src/crypto/utils.js (utils.js:3)
at __require (multicoin-address-validator.js?v=6adeb2e6:12)
at node_modules/multicoin-address-validator/src/ripple_validator.js (ripple_validator.js:1)
at __require (multicoin-address-validator.js?v=6adeb2e6:12)
at node_modules/multicoin-address-validator/src/currencies.js (currencies.js:1)
at __require (multicoin-address-validator.js?v=6adeb2e6:12)
at node_modules/multicoin-address-validator/src/wallet_address_validator.js (wallet_address_validator.js:1)
at __require (multicoin-address-validator.js?v=6adeb2e6:12)

Hello there!
A great library, but it is missing wallet validation for the NEAR blockchain. Are you planning to add this?

eos_validator.js can be updated with the following regex, to now allow any string with 1-12 chars, and that can contain dots as well: /^[a-z0-9.]{1,12}$/

Hi, very useful package!
Is it possible to add compatibility for digibyte addresses with "s" prefix?
As I understand, it is additional address type.
Thanks

Hey, it seems you can add Kusama address as polkadot when it shouldnt happen.
Also can there be Kusama address validation?

Thanks

Hi, i currently use your package!!

Is it possible to add compatibility for litecoin addresses with "ltc1" prefix?

When validating the address responds false.

wav.validate('ltc1q00045kp4d4t884428ua6j6tncx6g405y7epwju', 'ltc');
false

Thanks!

I am trying to push to a branch in order to make a pull request that adds ApeCoin, Curve DAT, Fantom, and Axe Infinity. When I try to git push I get the following error

> git push -u origin feature/add-ape-crv-ftm-axs
ERROR: Permission to christsim/multicoin-address-validator.git denied to lukabuz.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Is there a process to getting the permissions to create/push to a branch? There is no contributor guide so I figured I would create this issue to get some clarity/get the access.

Additional resource that should help to make the implementation

None of the addresses work

Legacy
zcU1Cd6zYyZCd2VJF8yKgmzjxdiiU1rgTTjEwoN1CGUWCziPkUTXUjXmX7TMqdMNsTfuiGN1jQoVN4kGxUR4sAPN4XZ7pxb

Sapling
zs1z7rejlpsa98s2rrrfkwmaxu53e4ue0ulcrw0h4x5g8jl04tak0d3mm47vdtahatqrlkngh9sly

Transparent
t14oHp2v54vfmdgQ3v3SNuQga8JKHTNi2a1

I don't believe this was an issue before recently, however 'DOT' validation suddenly seems to return false when an address is actually correct.

I've added polkadot.js' official methodology for address validation as a stop-gap measure to solve validation only for DOT in the meantime, but this should be checked up on.

Here's a valid DOT address: 5GrpknVvGGrGH3EFuURXeMrWHvbpj3VfER1oX5jFtuGbfzCE

And the result from the package:

(otherwise, great package!)

Hello,

Since the new release 7 hours ago minify is a new dependency: https://github.com/christsim/multicoin-address-validator/blame/master/package.json#L156

Is there a particular reason for this? Or should it be made a devDependency?

Thanks!

i work with several old essentially dead altcoins and it would not be reasonable to ask they be added to
the release currencies table.
it would be nice if my apps could insert mainnet/testnet/ticker/validatortype information for coins not already defined.
thanks.

Hello.
I am able to validate USDT ERC20 address with this bitcoin address: 16coSwd9rGA56UXeSeu5CnFgpyKMpgKyUo.

When validating any BSC address, it always returns an error. I've tried with 0xf1E398A22953ED3a2FBcebd990500Dc84D5C97E1 which is a valid BSC address although the response an error.

Line 606 in src/currencies.js should be bsc not bnb

This snippet used to return false.

WAValidator.validate('bc1ql08eyrk03qytqc5pdp5fnwpfh0x3y3k2skauvd', 'bch')

However, now breaks completely

Uncaught TypeError: Cannot read property 'prod' of undefined
    at Object.isValidAddress (../node_modules/multicoin-address-validator/src/crypto/segwit_addr.js:89:47)
    at Object.isValidAddress (.../node_modules/multicoin-address-validator/src/bitcoin_validator.js:84:78)
    at Object.isValidAddress (.../node_modules/multicoin-address-validator/src/bch_validator.js:46:80)
    at Object.validate (.../node_modules/multicoin-address-validator/src/wallet_address_validator.js:14:39)

cc: @christsim

As i was using this package and pushed our code to github, as jit test(Github automatic test) found that terser is in a version which can cause a Redos attack(as you can see in the image)

Can this be updated so we can use this package again? thanks!

Invoice validator and decoder

Can you add support for Aptos？

When I try to validate USDT it fails. I tried doing the following
var valid = WAValidator.validate(1KFzzGtDdnq5hrwxXGjwVnKzRbvf8WVxck, 'USDT');
As you can see I validated BTC address as USDT and it was returning true instead of false.

tried to validate the address btg1q74l7umjd4rt4uzlq98ps55sl9qx79tp29ftlfm
and btg1qvf4qf3tz4upuextefgzx0j9nsz78my4ggvrw9a

and get false the address is valid

If you pass a Bitcoin P2SH address into the validate function as so:

validate("32T3sEnqEjAKn8xJg6GKrnns6YXZ36TMR6", 'litecoin', 'prod');

It will return true. Litecoin P2SH addresses start with 'M', not '3'. Validate doesn't work properly here.

Hi, great little collection of address validators you've got here, very helpful and much appreciated!

I would like to suggest adding support for Yoroi browser extension wallet under the Cardano validator.

The validator for Daedalus rejects Yoroi as a valid wallet (and I noticed it also doesnt like exchange addresses).

Thanks!

Hi,

For your information, the api don't work on this address

let result = validator.validate("bchtest:qzt6flgcj0q3a9tz4078c6k0pfymsw4mkyklafezet", "BCH", "testnet")

can you add this crypto ?
HZMCOIN - HZM
KUSAMA - KSM
CURDE DAO TOKEN - CRV
THE SANBOX - SAND
1INCH - 1INCH
CHILIZ - CHZ

Please add validation of subaddresses: https://monerodocs.org/public-address/subaddress/

Hi guys!

It would be nice to support checking TON addresses (there is source code for addresses checking in tonweb library) - https://docs.ton.org/develop/dapps/cookbook#how-to-check-the-validity-of-a-ton-address

Hello!
Great npm package, using it in production. However, currently missing doge segwit validation support. Needs just one more line in src/currencies.js:
bech32Hrp: { prod: ['doge'], testnet: ['tdoge'] },

dependencies:

"multicoin-address-validator": "^0.4.12"

code:

WAValidator.validate('3KdLuLzTofVNMKKDWhyw81HUf9ZS4SSCDk', 'BTC', 'prod')

error:

TypeError: jsSHA is not a constructor
    at Object.sha256 (utils.js?14b3:90)
    at Object.sha256Checksum (utils.js?14b3:98)
    at getChecksum (bitcoin_validator.js?37f7:29)
    at getAddressType (bitcoin_validator.js?37f7:55)
    at isValidP2PKHandP2SHAddress (bitcoin_validator.js?37f7:67)
    at Object.isValidAddress (bitcoin_validator.js?37f7:86)
    at Object.validate (wallet_address_validator.js?1b74:12)

I tried like below

const valid = WAValidator.validate('TUTtVjNqCj3fndQ29YFKEdXvWwBwFihk1G', 'usdt', 'Tron')

console.log(valid) -> false

Could you assist me how to validate usdt on BSC, TRX, SOL, POLYGON, ..?

1HVDCg2KrPBH1Mg5SK9fGjAR9KVqyMMdBC is considered invalid but is a perfectly legal BTC address

https://www.blockchain.com/btc/address/1HVDCg2KrPBH1Mg5SK9fGjAR9KVqyMMdBC report it valid

Any specific reason?

Hey
There are premium EOS addresses that are less than 12 characters long, which are failing in your validation
example of an address wizdumb.ftw

any chance we can get this working for the solana blockchain?

Hi!
Can add support BitcoinCash format with prefix bchtest:: bchtest:pp92lyy7qguahkudxvjxhfg0zn8vfp6syy84fyza6u
It works fine without a prefix: pp92lyy7qguahkudxvjxhfg0zn8vfp6syy84fyza6u

I checked 'test' and 'both' of the networkType.
Test address: https://explorer.bitcoin.com/tbch/address/2Mz48JwfRr1HhMgn6M5BpwTJEB13GrEgZzt

Thanks!

Don't work validation some crypto address - BNB and USDT(TRC20)

Examples:

• BNB - bnb136ns6lfw4zs5hg4n85vdthaad7hq5m4gtkgf23
• USDT - TNfPeRfBSVxzMdhW9DGM9M4ubvwJrvG7Qo