Git Product home page Git Product logo

Comments (5)

HashEngineering avatar HashEngineering commented on June 26, 2024 1

That is because bech32 addresses are only currently supported for bitcoin.

See this line here:
https://github.com/christsim/multicoin-address-validator/blob/master/src/crypto/segwit_addr.js#L74

Ideally, the hrp for each coin should be specified in the src/currencies.js file.

from multicoin-address-validator.

sarahakhtar avatar sarahakhtar commented on June 26, 2024

We're also facing this issue.

from multicoin-address-validator.

rraina avatar rraina commented on June 26, 2024

@HashEngineering @sarahakhtar -- facing the same issue, and came to same root cause. @christsim are you open to accepting a PR for this?

from multicoin-address-validator.

christsim avatar christsim commented on June 26, 2024

@HashEngineering @sarahakhtar -- facing the same issue, and came to same root cause. @christsim are you open to accepting a PR for this?

I'm happy to accept a PR for this as long as it's pretty simple and doesn't include any unnecessary libraries.

None of my user's have complained about this yet, but I guess none of them are sending to segwit ltc addresses.

from multicoin-address-validator.

rraina avatar rraina commented on June 26, 2024

@christsim thank you for being open to a PR. I have made the requisite changes here: #22 .

I tried to keep the changes minimal, and follow the pattern already in the code. That being said, there is some opportunity to use babel to make the code more modern.

from multicoin-address-validator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.