Comments (4)
This bug has uncovered a lack of robustness in the calculation of some CALIPSO diagnostics. Some diagnostics produce wrong results when requested on model levels. This could be because they shouldn't be calculated on model levels or because the calculations are have bugs. If the former we need some quality control that checks for consistency between the requested configuration and outputs. I haven't fixed this in this change, I've created a new test (Global UM with diagnostics on model levels) that doesn't request the problematic diagnostics:
Lclzopaquecalipso=.false.,
Lclopaquemeanz=.false.,
Lclthinmeanz=.false.,
Lclopaquemeanzse=.false.,
Lclthinmeanzse=.false.,
Lclzopaquecalipsose=.false.,
from cospv2.0.
As part of this change, I've made some minor changes to plot_test_outputs.py so that it doesn't fail when variables are not present in the output file.
from cospv2.0.
@alejandrobodas
Thanks for finding this bug and cleaning it up!
We can leave this issue open, I will take a look at the calipso diagnostics on model/stat levels soon.
from cospv2.0.
PR #69 only partially addresses the issues raised here, so I'm reopening this issue.
from cospv2.0.
Related Issues (20)
- Inconsistent floating point types in quickbeam_optics HOT 10
- MISR outputs are not properly set to fillvalues for night columns HOT 16
- Bug in MODIS indexing of pressure input HOT 2
- MODIS Optical_Thickness_vs_ReffICE and Optical_Thickness_vs_ReffLIQ not masked for night columns HOT 3
- Striping caused by vertical interpolation routine HOT 15
- Example data for tests do not include any night columns HOT 2
- Allocation issue with MODIS/Cloudsat joint-products HOT 1
- cosp_diag_warmrain has wrong dimensions for variable frac_out / design flaw HOT 2
- cosp2_test reference (test) output is missing variables & needs versioning. HOT 4
- Python test script does not note occurrence of outputs that are not in the test dataset (Version check?) HOT 6
- Remove COSPv1.4 interface HOT 5
- Test case using global snapshot HOT 5
- Encoding version information in the KGO HOT 7
- CI test ifort broken HOT 1
- Implementation of CLARA simulator HOT 14
- hgt_matrix_half is used inconsistently HOT 1
- Masking fix in cosp_diag_warmrain? HOT 4
- Missing type specifier causing crash on Cori-KNL in running debug mode HOT 6
- Allocation of radar lookup table and delete unused variables
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cospv2.0.