Comments (3)
brhillman
commented on August 11, 2024
Another note on this, it looks like bugs like this could easily slip through the cracks because the input data used in the regression tests do not contain any nighttime points (the min and max of the sunlit variable are both equal to 1). Changing at least one column in these tests to be non-sunlit would improve the test coverage and make sure that code changes do not affect the day/night masking that is built into the code.
from cospv2.0.
dustinswales
commented on August 11, 2024
@brhillman
Thanks for pointing this out. You are correct, this is an error. Both modis_Optical_Thickness_vs_ReffICE and modis_Optical_Thickness_vs_ReffLIQ need to be set to R_UNDEF, analogous to how we treat modis_Optical_Thickness_vs_Cloud_Top_Pressure.
Would you be willing to open a PR with proposed fix? Also, I love the idea of having a daytime column in the sample data for regression testing. Would you be willing to provide a modified file as part of the PR?
Cheers,
Dustin
from cospv2.0.
brhillman
commented on August 11, 2024
@dustinswales no problem I'll put it together tomorrow.
from cospv2.0.
Related Issues (20)
- Subroutine COSP_OPAQ declares surfelev as optional HOT 8
- Inconsistent floating point types in quickbeam_optics HOT 10
- MISR outputs are not properly set to fillvalues for night columns HOT 16
- Bug in MODIS indexing of pressure input HOT 2
- Striping caused by vertical interpolation routine HOT 15
- Example data for tests do not include any night columns HOT 2
- Allocation issue with MODIS/Cloudsat joint-products HOT 1
- cosp_diag_warmrain has wrong dimensions for variable frac_out / design flaw HOT 2
- cosp2_test reference (test) output is missing variables & needs versioning. HOT 4
- Python test script does not note occurrence of outputs that are not in the test dataset (Version check?) HOT 6
- Remove COSPv1.4 interface HOT 5
- Test case using global snapshot HOT 5
- Encoding version information in the KGO HOT 7
- CI test ifort broken HOT 1
- Implementation of CLARA simulator HOT 14
- hgt_matrix_half is used inconsistently HOT 1
- Masking fix in cosp_diag_warmrain? HOT 4
- Calculation of cloudsat_preclvl_index fails when use_vgrid=.false. HOT 4
- Missing type specifier causing crash on Cori-KNL in running debug mode HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cospv2.0.