Comments (4)
The wrinkle to this is cloud-free scenes and dark scenes are both set to R_UNDEF in the modis-simulator. We want to include to former, but not the latter.
from cospv2.0.
@dustinswales I apporogize for this bug and late reply. The warm rain diagnostics did intend to use only daytime cloudy scenes, but actually the current code did not explicitly exclude dark-scene columns from the analysis.
To fix this bug, I will change the following two places as suggested by @brhillman and @dustinswales at the previous PR from 2019 (#36).
https://github.com/CFMIP/COSPv2.0/blob/master/src/cosp_stats.F90#L338
!! initialize
do i = 1, Npoints
if ( lwp(i) .eq. R_UNDEF ) then ! for non-sunlit columns
cfodd_ntotal(i,:,:,:) = R_UNDEF
wr_occfreq_ntotal(i,:) = R_UNDEF
icod(i,:,:) = R_UNDEF
else
cfodd_ntotal(i,:,:,:) = 0._wp
wr_occfreq_ntotal(i,:) = 0._wp
icod(i,:,:) = 0._wp
endif
enddo
https://github.com/CFMIP/COSPv2.0/blob/master/src/cosp_stats.F90#L345
if ( ( lwp(i) .le. CWP_THRESHOLD .and. lwp(i) .ne. R_UNDEF ) .or. &
I think this change will work appropriately for the issue. I push the bug-fix later via pull request.
from cospv2.0.
@dustinswales I think that we can now close this thread, as we have corrected this bug in the recent PR (#73). Thank you for your support.
from cospv2.0.
@takmichibata
Excellent!
Thanks for your work on this!
from cospv2.0.
Related Issues (20)
- MODIS Optical_Thickness_vs_ReffICE and Optical_Thickness_vs_ReffLIQ not masked for night columns HOT 3
- Striping caused by vertical interpolation routine HOT 15
- Example data for tests do not include any night columns HOT 2
- Allocation issue with MODIS/Cloudsat joint-products HOT 1
- cosp_diag_warmrain has wrong dimensions for variable frac_out / design flaw HOT 2
- cosp2_test reference (test) output is missing variables & needs versioning. HOT 4
- Python test script does not note occurrence of outputs that are not in the test dataset (Version check?) HOT 6
- Remove COSPv1.4 interface HOT 5
- Test case using global snapshot HOT 5
- Encoding version information in the KGO HOT 7
- CI test ifort broken HOT 1
- Implementation of CLARA simulator HOT 14
- hgt_matrix_half is used inconsistently HOT 1
- Calculation of cloudsat_preclvl_index fails when use_vgrid=.false. HOT 4
- Missing type specifier causing crash on Cori-KNL in running debug mode HOT 6
- Allocation of radar lookup table and delete unused variables
- download_test_data.sh drive links HOT 3
- add MODIS joint histgram diagnostics
- Inconsistent unit labels for hgt_matrix
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cospv2.0.