cccraig / mugshot Goto Github PK

Hi,

I cannot see the button on the photo page: https://reisishot.pictures/picture/379/category/jahreszeiten/winter (plugin disabled), Latest piwigo + bootstrap darkroom)

When the plugin is installed it should automatically create the tagger group and add the installing person (who's obviously an admin) as a member of that group.

updateWrapper sets the top style for MugShotDiv to 0 overriding the padding.top value in the theImage parent div causing a misalignment of MugShotDiv relative to the underlying image.

The fix is simple, remove the line setting the top to 0:

-    w.style.top = '0px';

hi
error syntax unexpected value ?? and no configuration active

Fresh installation of piwigo 13.8.0 fails to activate MugShot.
When I add a new plugin / search MugShot, piwigo offers to add version 2.0.3 from site https://de.piwigo.org/ext/extension_view.php?eid=910

Once added (message - successfully installed), it displays version 2.0.2 and appears on the list of available updates 2.0.2 -> 2.0.3. I updated (successfully), but it remains on version 2.0.2 an re-appears on the list.

I've found advice to fix the version number manually in piwigo/plugins/MugShot/main.inc.php (was still 2.0.2 there).
OK so far, the updates available loop disapperared.

But I can't activate the MugShot plugin even with the correct version number.
While trying, an error message appears with no further details.

Piwigo 13.8.0
Ubuntu 22.04
PHP: 8.1.21

After upgrade to php 7.3 the following warning is displayed in the admin page:
Warning: Use of undefined constant PSHARE_ADMIN_BASE_URL - assumed 'PSHARE_ADMIN_BASE_URL' (this will throw an Error in a future version of PHP).
This also effects the changes for a better UI management, I added a comment in respective pull request.

SOLUTION => ? => replace PSHARE_ADMIN_BASE_URL with MUGSHOT_ADMIN

BTW, I have facial detection and recognition working. I did it in two parts, detection of faces in photos and matching with previously identified faces. Detection creates the entry in face_tag_positions with tag_id set to null. I added a menu block for MugShot with two items. "Unidentified People" and "Unconfirmed Matched People. The first link displays an index page of all faces with null for a tag_id. The latter displays all the ones with confirmed set to false. This only happens with software created ones using detection and mapping. In the "Capone" UI there is an additional icon (checkmark) that sets confirmed to true. Confirmed faces have green bounding boxes, the others are red. The actual detection and matching is done by a separate python program that can be run on the same machine or a separate more powerful one or one that you have root access on.

Originally posted by @Robert-Nelson in #28 (comment)

The autocomplete of the Chrome browser (at Version 94) is overlapping the Plugin's name suggestion box.

I have to press escape to reach the real box.

I am struggling to resolve an error with the Mugshot plugin on a fresh install of Piwigo. When I install mugshot it shows a red caution icon in the top left corner of the mugshot plugin and I get a pop when I enable it that says an error has occurred. When I look at apache2 error logs this show up in there. I have followed a few thread online but nothing seems to help. Any help you can provide would be greatly appreciated.

[Wed Apr 06 05:05:31.410064 2022] [php7:warn] [pid 6882] [client 172.70.131.179:20070] PHP Warning: [mysql error 1062] Duplicate entry 'MugShot' for k
ey 'PRIMARY'\nINSERT INTO piwigo_config (param,value,comment) VALUES ("MugShot","","MugShot configuration values"); in /var/www/html/piwigo/include/dbl
ayer/functions_mysqli.inc.php on line 847, referer: https://www.hessel.family/admin.php?page=plugins&tab=installed

Piwigo 12.2.0
Operating system: Linux
PHP: 7.4.28
MySQL: 5.5.5-10.4.24-MariaDB-1:10.4.24+maria~focal [2022-04-06 05:18:52]
Graphics Library: External ImageMagick 6.9.10-23
Cache size 20 Mo

Plugins
Community
LocalFiles Editor
Mug Shot
No Stats For Robots
Take A Tour of Your Piwigo
VideoJS

If a photo has tags on it, the existing ones have to be deleted if new ones are to be added.

You forgot to update MUGSHOT_VERSION to 2.0.3 in main.inc.php.
I thinkt that's the reason why Piwigo won't stop showing me that there is an update available.

I think it's appropriate to remove all the training images / data if the plugin is uninstalled. However, a warning should be presented and the database table should be cleanup so there aren't rows referencing images that don't exist anymore.

Updates to make the plugin compatible with piwigo 11.

The SAVE/DONE button should be moved to the bottom of the picture where it is far less likely to cover part of a face.

After adding the Mugshot plugin, I get an error when reloading the piwigo page:

Fatal error: Call to undefined function array_column() in /var/www/html/piwigo/plugins/MugShot/main.inc.php on line 92

After inspecting the code, It looks like the "array_column" function indeed is missing from the file.

Completing a fresh install of Piwigo v12 there is a constant error with MugShot not being compatible with the current version. Even if I manually download it still shows 2.0.2 instead of 2.0.3.

Just installed piwigo for the first time, created one album and uploaded some test photo's.
Works fine without errors. Using the bootstrap darkroom theme.
Activated the MugShot plugin. and the following errors show:

Warning: count(): Parameter must be an array or an object that implements Countable in /zzz/zzz/piwigo/plugins/MugShot/main.inc.php on line 163

Warning: Cannot modify header information - headers already sent by (output started at /zzz/zzz/piwigo/plugins/MugShot/main.inc.php:163) in /zzz/zzz/piwigo/include/page_header.php on line 86

Hence the MugShot plugin isn't working, the button isn't showing. From the documentation I understand that the bootstrap darkroom theme is compatible. Tried another, same errors. Deactivated MugShot and errors disappeared.

Anybody any suggestions?

I upgraded my Piwigo instance. It did not show MugShot as compatible, still I tried :-)

The following issues appear:

When reactivating the plugn "an error occured" and ws.php responds in the network tab:

<b>Warning</b>:  [mysql error 1062] Duplicate entry 'MugShot' for key 'PRIMARY'
INSERT INTO piwigo_config (param,value,comment) VALUES ("MugShot","","MugShot configuration values"); in 
<b>/var/www/virtual/example/html/include/dblayer/functions_mysqli.inc.php</b> on line <b>847</b><br />
</pre>{"stat":"ok","result":true}

At the end of gallery pages I get

Warning
: unserialize() expects parameter 1 to be string, array given in
/var/www/virtual/example/html/plugins/MugShot/main.inc.php
on line
247

New face-tags are not saved EDIT: The are saved - I just did not hit the save button :-)

Should have a setting to make the tagging feature be on all the time. So when you go to the next image you don't have to constantly be clicking the button. It's just "active".

1. Need to auto-save when you move to the next screen. Maybe make it auto post after selecting a name (for existing tags)?

As an administrator of a Piwigo site, I want to be able have automatic facial recognition run across all of my photos.

• After the facial recognition has completed I want to be able to assign names to the recognized faces.
• As more data is entered by users, the facial recognition should be able to be run again in order improve it's accuracy.
• When new photos are uploaded, automatically run the facial recognition suite and make recommendations

New installation Piwigo 13.7.0, installed Mugshot get "doesn't support this version of Piwigo" message;go to Plugins/Check for updates, see that MugShot 2.0.2-> 2.0.3 is avail, so I select 'Install' and get "All plugins are up to date" and go back to Plugins/List/Deactivated.

MugShot is still listed with red triangle error "WARNING: this plugin does not seem to be compatible with this version of Piwigo" and it still reports Ver 2.0.2

Try activating anyway, get "an error occurred" toast message and PHP logs error:

[02-Jun-2023 13:47:58 America/Los_Angeles] PHP Fatal error:  Uncaught mysqli_sql_exception: You do not have the SUPER privilege and binary logging is enabled (you *might* want to use the less safe log_bin_trust_function_creators variable) in /home/dh_kgmndt/kmpics.stidolph.com/piwigo/include/dblayer/functions_mysqli.inc.php:132
Stack trace:
#0 /home/dh_kgmndt/kmpics.stidolph.com/piwigo/include/dblayer/functions_mysqli.inc.php(132): mysqli->query('CREATE TRIGGER ...')
#1 /home/dh_kgmndt/kmpics.stidolph.com/piwigo/plugins/MugShot/include/helpers.php(75): pwg_query('CREATE TRIGGER ...')
#2 /home/dh_kgmndt/kmpics.stidolph.com/piwigo/plugins/MugShot/maintain.inc.php(43): create_tag_drop_trigger()
#3 /home/dh_kgmndt/kmpics.stidolph.com/piwigo/admin/include/plugins.class.php(139): MugShot_maintain->install('2.0.2', Array)
#4 /home/dh_kgmndt/kmpics.stidolph.com/piwigo/admin/include/plugins.class.php(191): plugins->perform_action('install', 'MugShot')
#5 /home/dh_kgmndt/kmpics.stidolph.com/piwigo/include/ws_functions/pwg.extensions.php(76): plugins->perform_action('activate', 'MugShot')
#6 /home/dh_kgmndt/kmpics.stidolph.com/piwigo/include/ws_core.inc.php(600): ws_plugins_performAction(Array, Object(PwgServer))
#7 /home/dh_kgmndt/kmpics.stidolph.com/piwigo/include/ws_protocols/rest_handler.php(41): PwgServer->invoke('pwg.plugins.per...', Array)
#8 /home/dh_kgmndt/kmpics.stidolph.com/piwigo/include/ws_core.inc.php(281): PwgRestRequestHandler->handleRequest(Object(PwgServer))
#9 /home/dh_kgmndt/kmpics.stidolph.com/piwigo/ws.php(22): PwgServer->run()
#10 {main}
  thrown in /home/dh_kgmndt/kmpics.stidolph.com/piwigo/include/dblayer/functions_mysqli.inc.php on line 132

From the helpers.php file I see the comment around line 68 that indicates you know this "is silently failing" so this Issue might be just to alert you that it specifically seems bad for MugShot if deployed on a server that doesn't have full permissions; for example, Dreamhost Shared Hosting doesn't allow creating Triggers (https://help.dreamhost.com/hc/en-us/articles/115000263911-MySQL-limitations-due-to-shared-hosting
says Shared: Allow existing triggers to be used (creating of new triggers is not supported)

If two faces are close together one face can be successfully tagged but the second face may be blocked because the first tag frame has a higher z-index than the image. This blocks the mouse over event and halts the dragging of the second frame. This can cause other issues, like releasing the mouse button but the frame drags with you.

Proposed fix is to dynamically change the z-index of previously created frames to hide them while the new frame is being drawn. Then revert the z-index after name has been entered.

Hi :-)

Can you duplicate en_US to en_UK
Add file description.txt

and

Can you add Piwigo-TranslationTeam user for autorise add language

When reactivating the disabled plugin, I get the following error:

[Sat Feb 04 18:04:58.836146 2023] [proxy_fcgi:error] [pid 737805] [client 178.39.186.97:57306] AH01071: Got error 'PHP message: PHP Fatal error:  Uncaught mysqli_sql_exception: Duplicate entry 'MugShot' for key 'piwigo_config.PRIMARY' in /home/redacted/public_html/include/dblayer/functions_mysqli.inc.php:132\nStack trace:\n#0 /home/redacted/public_html/include/dblayer/functions_mysqli.inc.php(132): mysqli->query()\n#1 /home/redacted/public_html/plugins/MugShot/include/helpers.php(84): pwg_query()\n#2 /home/redacted/public_html/plugins/MugShot/maintain.inc.php(40): create_facetag_table()\n#3 /home/redacted/public_html/plugins/MugShot/maintain.inc.php(65): MugShot_maintain->install()\n#4 /home/redacted/public_html/admin/include/plugins.class.php(195): MugShot_maintain->activate()\n#5 /home/redacted/public_html/include/ws_functions/pwg.extensions.php(71): plugins->perform_action()\n#6 /home/redacted/public_html/include/ws_core.inc.php(600): ws_plugins_performAction()\n#7 /home/redacted/public_html/include/ws_protocols/rest_handler.php(41): PwgServer->invoke()\n#8 /home/redacted/public_html/inc...', referer: https://www.redacted.com/admin.php?page=plugins&tab=installed

I need to then remove the MugShot entry from the DB in order to reactivated the plugin. Piwigo 13.5.0, PHP 8.2.2.

Thanks for a great plugin!

"I've added a small piece of code that will crop user faces based on the select frame and save the crop to a folder with 0760 permission. The code uses Imagick to do this and will simply ignore this section if Imagick is not found. This is an optional feature which defaults to off. "

How to switch this feature on?

getting a floating error at the top of the homepage.

Warning: array_intersect(): Argument #1 is not an array in /var/www/html/plugins/MugShot/main.inc.php on line 45

The deletion of the tag from piwigo_image_tag doesn't include the image_id in the where clause so the tag gets deleted for all images.

We want to use the plugin to tag old family photos

$lang['Name that mug!'] = 'Name that mug!'; 

seems not fully appropriate. Just wondering if it would it be okay to rename that to "name that face" ?

We have a quite special case where we scan a old photo album page with multiple pictures.
In that case, one and the same person can appear twice in the same page / .JPG file.

Now only the last tag is saved.

Can we an add option to save more tags on the same picture of the same person?