Comments (5)
@LukeWinikates any thoughts on picking git (by a tag) vs githubRelease fetch types to fetch source code?
from vendir.
I think using the git fetch type is a viable workaround. Honestly, for our use case, there doesn't seem to be anything in the source code that we actually need from the git repo either, but we were attempting to conform to a vendir usage pattern established by the codebase we were contributing to.
Other packages in the repository we were adding to had a pattern of using vendir
to pull in yaml
files for Kubernetes deployments, which then fed into using imgpkg
to resolve the image versions in those yamls
into a specific image sha
. We wanted to follow that same pattern to document our upstream open-source dependency, but it turns out that none of our dependencies ship yaml deployment manifests with their releases, so the vendir -> yaml -> imgpkg -> resolved sha
pipeline didn't pan out in those cases.
We ended up not using vendir at all for those packages - the downside is that for other packages in that repository the vendir.yaml file is the source of truth for their upstream dependencies, whereas for our contributions, it's going to be maintained by editing the individual image tags in the yaml files we author ourselves.
I will say that the error message in this case made me think I was getting something wrong in my yaml paths, so I spent a fair amount of time thinking the problem was something on my local filesystem. I took a fair amount of time and trial and error to figure out that it was actually the json response of the specific release that was causing the error. Detecting the specific case of a release with no assets and printing an error message that says "error: no files in release, try a git
resource instead`" would be a good thing to do, I think. Happy to submit a PR for that, if it would be welcomed.
from vendir.
"error: no files in release, try a git resource instead`" would be a good thing to do, I think. Happy to submit a PR for that, if it would be welcomed.
i think that would be a helpful addition.
it's going to be maintained by editing the individual image tags in the yaml files we author ourselves.
so it sounds like the asset that you actually care about is the image tag and that image tag is part of somebody else yaml file. hmm ill have to chew on that if vendir can be (/should be) helpful in such scenario (i could imagine having vendir provide some metadata that could be used to "generate" a file that would be a ytt overlay -- sounds a little weird... will think more)?
from vendir.
This issue is being marked as stale due to a long period of inactivity and will be closed in 5 days if there is no response.
from vendir.
This issue is being marked as stale due to a long period of inactivity and will be closed in 5 days if there is no response.
from vendir.
Related Issues (20)
- Confusion about what `path` actually represents HOT 2
- Sign `vendir` binaries while releasing them HOT 1
- Error when using --directory and --locked option at the same time HOT 1
- Use vanity urls to change the go module name
- issue with lazy sync functionality HOT 1
- Vendir directory sync ignores overlapping paths on directories HOT 3
- Timeouts when attempting to use vendir with a registry with a significant amount of tags HOT 3
- Concurrent vendir processes interfere with each other
- Lazy sync doesn't work for the same path in different forms HOT 1
- Vendir allows self-destructing configuration HOT 4
- Vendir is failing to fetch content if private-key does not have newline at the end
- Vendir allows to use unsafe paths in configuration HOT 2
- vendir sync --json swallows error HOT 8
- Syncing OCI helm chart with semver version range fails if tag has a v prefix HOT 2
- Vendir sync with http on windows fails because of a missing close before rename HOT 2
- Support forcing basic authentication for git HOT 4
- Version checker errors when consumed as library
- Update copyright headers
- can't install on old fedora HOT 2
- Configurable output verbosity HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vendir.