Comments (2)
In the community meeting, we agreed that the fix is to disallow paths outside the current working directory (CWD). Defining the CWD is important here. If I remember correctly, this is the logic (in the order of priority):
- if the
--chdir
argument is supplied, its value is CWD; - if the vendir configuration file is on the disk, its location is CWD;
- if the vendir configuration is passed via stdin, the current directory (
$PWD
) is CWD.
@joaopapereira I'm not entirely sure about the last two points. Could you confirm or correct this? Are there more cases?
from vendir.
- if the vendir configuration file is on the disk, its location is CWD;
I assume that all paths will have to start in the vendir configuration file, so CWD is where that file is
- if the vendir configuration is passed via stdin, the current directory ($PWD) is CWD.
In this scenario, we have to assume that CWD is the current directory.
I think these are all the scenarios, @neil-hickey @cppforlife do you think we might have any other scenarios?
from vendir.
Related Issues (20)
- Error when using --directory and --locked option at the same time HOT 1
- Use vanity urls to change the go module name
- issue with lazy sync functionality HOT 1
- Vendir directory sync ignores overlapping paths on directories HOT 3
- Timeouts when attempting to use vendir with a registry with a significant amount of tags HOT 3
- Concurrent vendir processes interfere with each other
- Lazy sync doesn't work for the same path in different forms HOT 1
- Vendir allows self-destructing configuration HOT 4
- Vendir is failing to fetch content if private-key does not have newline at the end
- vendir sync --json swallows error HOT 8
- Syncing OCI helm chart with semver version range fails if tag has a v prefix HOT 2
- Vendir sync with http on windows fails because of a missing close before rename HOT 2
- Support forcing basic authentication for git HOT 4
- Version checker errors when consumed as library
- Update copyright headers
- can't install on old fedora HOT 2
- Configurable output verbosity HOT 1
- A 'dev' mode to preserve local changes in git/hg repositories HOT 4
- Panic in `vendir sync` HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vendir.