vendir sync --json swallows error about vendir HOT 8 OPEN

@hans-d I tried to reproduce the issue with config

apiVersion: vendir.k14s.io/v1alpha1
kind: Config
directories:
- path: sponnet
  contents:
  - path: xyz
    http:
      url: https://github.com/spinnaker/sponnet/archive/refs/tags/v1.26.0.tar.gz123

First I run without --json and got error message in output:

$ vendir sync -f vendir.yaml 
Fetching: sponnet + xyz (http from https://github.com/spinnaker/sponnet/archive/refs/tags/v1.26.0.tar.gz123)

vendir: Error: Syncing directory 'sponnet':
  Syncing directory 'xyz' with HTTP contents:
    Downloading URL:
      Expected 200 OK, but was '404 Not Found'

With --json, it exited without any error or any log:

$ vendir sync -f vendir.yaml --json

Did you get something different output if yes can you please add here your config and steps you followed? (It will be helpful in future)

After trying out above config I can see there is bug in vendir sync --json output. In case of failure with flag --json as well it should show error message.

from vendir.

This is the kind of thing i'm facing. It should produce an error (stderr or in json), and exit with a non-zero status

from vendir.

@Zebradil what do you think about this?

@100mik I think that, in case of an error, vendir --json should:

• print nothing to the stdout
• print a plain text error to the stderr
• exit with a non-zero exit code

from vendir.

Hey @hans-d can you provide a sample vendir.yaml for us to look at?
It sounds like you have ../ as part of a path, is that correct?

from vendir.

The '../' is part of the source directory:

apiVersion: vendir.k14s.io/v1alpha1
kind: Config

directories:

  - path: somewhere
    contents:
      - path: over/the/rainbow
        directory:
          path: ../src/foo # non-existing

from vendir.

This issue is seen in kbld & imgpkg too?

from vendir.

Not using those, so can't say.

from vendir.

Same issues seen in imgpkg and kbld as well. Issues created are:
carvel-dev/kbld#455
carvel-dev/imgpkg#631

from vendir.