Make some georeference analyses less demanding about camshaft HOT 14 CLOSED

If params that we send to our geocoder-service are optional then we can make those params optional in analysis too.

from camshaft.

I've checked with data-services and those params can be optional.

from camshaft.

That's great! Then all we need to do is update the camshaft-reference to make them optional, right?

from camshaft.

that's it! I'll take care of it.

from camshaft.

I cannot find the reference for this ticket in the cartodb repo.

from camshaft.

There's no ticket for that in the cartodb repo. Once the reference is updated, the UI won't require those fields.

from camshaft.

Cooleo, thanks!

from camshaft.

Hey there! I've noticed a couple things here (georeference-admin-region).

• The city parameter is part of the code (we don't geocode cities as regions right now besides the namedplaces geocoding), which I assume is a typo when copy-pasting analysis :)
• Only the admin1 function is being used (unless I missed something). For countries, the admin0 function should be used. I found out about this while debugging the country decoder which seems to be trying something like geocode_admin1_polygon('Spain, Spain').

from camshaft.

@iriberri thanks for your comments. I'm fixing them.

from camshaft.

Only the admin1 function is being used (unless I missed something). For countries, the admin0 function should be used. I found out about this while debugging the country decoder which seems to be trying something like geocode_admin1_polygon('Spain, Spain').

AFAIK we don't have analysis for country geocoding.

from camshaft.

It's there. Is the admin region, when the country field is empty

On Jul 13 2016, at 12:57 pm, Daniel <[email protected]> wrote:

Only the admin1 function is being used (unless I missed something). For
countries, the admin0 function should be used. I found out about this while
debugging the country decoder which seems to be trying something like
geocode_admin1_polygon('Spain, Spain').

AFAIK we don't have analysis for country geocoding.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on
GitHub,
or mute the
thread.

from camshaft.

Opps! I didn't know that. Fixing it.

from camshaft.

FYI: from #138, I've added a new analysis: georeference-country. This analysis receives a mandatory param country_colum as column value.

from camshaft.

Closed by #141

from camshaft.