Git Product home page Git Product logo

Comments (9)

rochoa avatar rochoa commented on July 1, 2024

I don't understand the context/problem. 😕

from camshaft.

Algunenano avatar Algunenano commented on July 1, 2024

Case 1:

  • Modify a analysis (for example AOI) with cache and change the name of an output column.
  • Forget to update version.
    Current result: Map fails to instantiate and it's inaccessible in builder.

Case 2:

  • Modify a analysis (for example AOI) with cache and change the name of an output column.
  • Update version.
    Current result: The analysis is rerun automagically.

This would address the first case and enables that the rerun in Case 2 is optional (since the map wouldn't be broken).

from camshaft.

rochoa avatar rochoa commented on July 1, 2024

Understood. Thank you.

About the "Case 2": As re-running is optional, how do we enable the user to re-run it?

from camshaft.

Algunenano avatar Algunenano commented on July 1, 2024

My idea is that this could be done in the UI after the instantiation (something like This analysis can be updated).
That should be another ticket after this one since it'd involve:

  • Not doing the version update automatically when a difference is found.
  • Returning extra information in the instantiation.
  • Adding the UI stuff with the alert to trigger the update.

from camshaft.

rochoa avatar rochoa commented on July 1, 2024

And how that would work at API level?

from camshaft.

Algunenano avatar Algunenano commented on July 1, 2024

My initial idea is to add an extra (non-persisted) state to the analysis, upgradable which means that the analysis is ready but there is an update available. Then to update it you could push the new config as if the parameters had changed.

The analysis backend to handle changes seems to be defined in Builder (app/controllers/carto/api/analyses_controller.rb and app/models/carto/analysis.rb) so I expect some changes to be needed there to handle version mismatches in a different way.

from camshaft.

juanignaciosl avatar juanignaciosl commented on July 1, 2024

We've not deployed the new metadata columns for street geocoding because this affects us. Old analyses fail with this error:

pasted image at 2018_07_25 03_47 pm

The fix is simple: either change the data or, more correctly, change the analysis version to force rerunning it. But this implies a cost, so we chose not to expose those columns.

from camshaft.

Algunenano avatar Algunenano commented on July 1, 2024

Was the initial issue for this ticket solved with #372 ?

from camshaft.

dgaubert avatar dgaubert commented on July 1, 2024

Was the initial issue for this ticket solved with #372 ?

Yes, it was.

from camshaft.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.