Git Product home page Git Product logo

Comments (3)

lorumic avatar lorumic commented on June 4, 2024 1

The issue seems to still be there. If you put search box component side by side the search and filter there is a 1px difference.

Hey @bartaz - I think you wanted to post this comment in the PR. This is the issue :)

from vanilla-framework.

bartaz avatar bartaz commented on June 4, 2024

The issue seems to still be there. If you put search box component side by side the search and filter there is a 1px difference.

image

I'm not certain, but possibly there is a miscalculation here:

vanilla-framework/scss/_patterns_search-and-filter.scss

Line 22 in d4a5eb6

$input-height: calc(map-get($line-heights, default-text) + $input-vertical-padding + $spv-nudge - $input-border-thickness);

This may need to be corrected to include the values from

vanilla-framework/scss/_base_forms.scss

Lines 24 to 38 in d4a5eb6

background-color: $colors--theme--background-inputs;
border: 0 solid transparent;
border-bottom: $input-border-thickness solid $colors--theme--border-high-contrast;
border-radius: 0;
color: $colors--theme--text-default;
font-family: unquote($font-base-family);
font-size: 1rem;
font-weight: $font-weight-regular-text;
line-height: map-get($line-heights, default-text);
margin-bottom: $input-margin-bottom;
min-width: 8em;
padding-left: $sph--small;
padding-right: $sph--small;
vertical-align: baseline;
width: 100%;
input, so take the same line height, paddings and a single border.

from vanilla-framework.

bartaz avatar bartaz commented on June 4, 2024

The issue seems to still be there. If you put search box component side by side the search and filter there is a 1px difference.

Hey @bartaz - I think you wanted to post this comment in the PR. This is the issue :)

Ah, yes, I don't know how this happened. I must have clicked a wrong link.

from vanilla-framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.