Comments (2)
Yes, the issue is there is no "selected" style at all in the picker. The style of the buttons reflects the theme itself, but none have a selected state.
It was kind of quickly hacked in when we worked on theming migration with guests, so it's not ideal.
If you want to play around @jmuzina you can try replacing current switcher with more appropriate component such as segmented control: https://vanillaframework.io/docs/patterns/segmented-control.
One issue you may get into is that currently Vanilla examples are not implementing the themes in consistent way, and not all of them have a default class name set on body, so it's not always trivial to tell which is the "current" theme when example loads.
Another cool feature we could introduce would be to reflect the theme in the URL /example?theme=dark
and make it load in desired theme. This would allow us to easier test the same example in different themes just by changing the URL.
Feel free to play around during this week, and maybe we can turn this into something you could be working on while we are in Madrid.
from vanilla-framework.
IMO just the words are enough, you could say:
Theme: [ dark ][ light ][ white ]
from vanilla-framework.
Related Issues (20)
- Latest Vanilla turns white links in global nav black HOT 1
- row--25-75 - col containers do not set grid context properly HOT 1
- Grid: provide 3 levels of nesting HOT 9
- Unclear usage of horizontal lines between old hr docs and new rule component
- Adding grid usage explanation to app layout when l-nav is in is-collapsed state. HOT 2
- Heading anchor links styling HOT 13
- Collapsable side panel HOT 5
- (Firefox) Holding shift while clicking a checkbox causes the click to not be registered HOT 7
- Sliding navigation: "Back" button chevron points to right instead of left
- Make dark theme hrs consistent with light theme HOT 1
- Dividers in equal heights component don't work well when items are hidden on smaller screens HOT 1
- p-equal-height-row: remove padding-bottom, make separators muted HOT 3
- Add left and right chevrons to vanilla icon set HOT 5
- Implement Expand and Copy functionality for Code snippets HOT 1
- Parent background highlights when clicking on child button in navigation dropdown item HOT 1
- grid bug - default span of elements without col-* class inside row is hard-coded to 12 for desktop HOT 1
- The tabs component is being used with a single tab. AFAIK, this is not intended usage. Should the documentation disallow it? HOT 2
- The keyword 'searchfield-cancel-button' used on the 'appearance' property was deprecated and has now been removed. It will no longer have any effect. HOT 1
- Misleading icon import documentation HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vanilla-framework.