Git Product home page Git Product logo

Comments (2)

bartaz avatar bartaz commented on June 5, 2024 1

Yes, the issue is there is no "selected" style at all in the picker. The style of the buttons reflects the theme itself, but none have a selected state.

It was kind of quickly hacked in when we worked on theming migration with guests, so it's not ideal.

If you want to play around @jmuzina you can try replacing current switcher with more appropriate component such as segmented control: https://vanillaframework.io/docs/patterns/segmented-control.

One issue you may get into is that currently Vanilla examples are not implementing the themes in consistent way, and not all of them have a default class name set on body, so it's not always trivial to tell which is the "current" theme when example loads.

Another cool feature we could introduce would be to reflect the theme in the URL /example?theme=dark and make it load in desired theme. This would allow us to easier test the same example in different themes just by changing the URL.

Feel free to play around during this week, and maybe we can turn this into something you could be working on while we are in Madrid.

from vanilla-framework.

lyubomir-popov avatar lyubomir-popov commented on June 5, 2024

IMO just the words are enough, you could say:

Theme: [ dark ][ light ][ white ]

from vanilla-framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.