Comments (5)
If we have SVGs for the icons, we can add those to the icon set I guess.
from vanilla-framework.
@bartaz we do have them i'll upload them onto the assets
from vanilla-framework.
@camillet16 for Vanilla they don't need to be in assets, as we inline them in CSS.
Are there in icons drive folder (could you link those)? Or add them to comment here, and I can use the files to add to Vanilla CSS.
from vanilla-framework.
Here they are. I'm not sure if they're on a drive somewhere.
from vanilla-framework.
Is there a reason we would need to add new SVGs to the project for left/right chevrons instead of adding new left & right classes that perform the icon rotation (upstreaming the rotation work that some projects are doing)?
VF currently uses a single SVG (pointing downward) for all chevrons:
Then it rotates according to applied class (example is for p-icon--chevron-up
):
vanilla-framework/scss/_patterns_icons.scss
Line 133 in 4109529
Here's a link to a proposed change that doesn't need any SVGs to be changed:
vanilla-framework/scss/_patterns_icons.scss
Line 132 in b2fcc7d
Otherwise, I think we'd need to re-implement the chevron icons slightly as the vf-icon-chevron-themed
mixin uses the same SVG for all directions.
Edit: See comment from Lyubo - we can use rotated chevron icon instead of using a new chevron asset
from vanilla-framework.
Related Issues (20)
- Heading anchor links styling HOT 13
- Collapsable side panel HOT 5
- (Firefox) Holding shift while clicking a checkbox causes the click to not be registered HOT 7
- Sliding navigation: "Back" button chevron points to right instead of left
- Make dark theme hrs consistent with light theme HOT 1
- Dividers in equal heights component don't work well when items are hidden on smaller screens HOT 1
- p-equal-height-row: remove padding-bottom, make separators muted HOT 3
- Implement Expand and Copy functionality for Code snippets HOT 1
- Parent background highlights when clicking on child button in navigation dropdown item HOT 1
- Examples theme picker does not reflect selected theme HOT 2
- grid bug - default span of elements without col-* class inside row is hard-coded to 12 for desktop HOT 1
- The tabs component is being used with a single tab. AFAIK, this is not intended usage. Should the documentation disallow it? HOT 2
- The keyword 'searchfield-cancel-button' used on the 'appearance' property was deprecated and has now been removed. It will no longer have any effect. HOT 1
- Misleading icon import documentation HOT 1
- Remove distinction between horizontal rules with and without margin HOT 4
- Filter bots from contributors list
- extend navigation separators in the application layout navigation
- Change icon alignment to `middle` when next to paragraph text
- p-modal__header need overflow:auto to prevent margin collapse HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vanilla-framework.